replace_symbolt must consider all non-lvalues

Literal constants are not the only ones: for example, address-of isn't an lvalue
either. Make is_lvalue globally available to accomplish this.

Author: tautschnig

src/util/replace_symbol.cpp

@@ -9,6 +9,7 @@ Author: Daniel Kroening, [email protected]
 #include "replace_symbol.h"
 
 #include "base_type.h"
+#include "expr_util.h"
 #include "invariant.h"
 #include "namespace.h"
 #include "std_types.h"
@@ -420,7 +421,7 @@ bool address_of_aware_replace_symbolt::replace_symbol_expr(
 
   const exprt &e = it->second;
 
-  if(require_lvalue && e.is_constant()) // Would give non l-value.
+  if(require_lvalue && !is_lvalue(e))
     return true;
 
   static_cast<exprt &>(s) = e;

unit/util/replace_symbol.cpp

@@ -82,6 +82,13 @@ TEST_CASE("Lvalue only", "[core][util][replace_symbol]")
     to_index_expr(to_address_of_expr(binary.op1()).object());
   REQUIRE(to_array_type(index_expr.array().type()).size() == c);
   REQUIRE(index_expr.index() == c);
+
+  address_of_exprt address_of(s1);
+  r.erase("a");
+  r.insert("a", address_of);
+
+  REQUIRE(r.replace(binary) == true);
+  REQUIRE(binary.op0() == address_of_exprt(s1));
 }
 
 TEST_CASE("Replace always", "[core][util][replace_symbol]")