Add and check type of pointees in memory analyzer

GDB does not know (the CBMC) types but the resulting symbol table requires them.
Also prevents catch-by-value error when compiled with gcc-8.

Author: petr-bauch

src/memory-analyzer/analyze_symbol.cpp

@@ -68,7 +68,7 @@ void gdb_value_extractort::analyze_symbol(const irep_idt &symbol_name)
 
     add_assignment(symbol_expr, target_expr);
   }
-  catch(gdb_interaction_exceptiont e)
+  catch(gdb_interaction_exceptiont &e)
   {
     throw analysis_exceptiont(e.what());
   }
@@ -248,7 +248,9 @@ exprt gdb_value_extractort::get_non_char_pointer_value(
   }
   else
   {
-    return it->second;
+    const symbol_exprt typed_symbol_value = symbol_exprt{
+      to_symbol_expr(it->second).get_identifier(), expr.type().subtype()};
+    return typed_symbol_value;
   }
 }
 
@@ -304,7 +306,9 @@ exprt gdb_value_extractort::get_pointer_value(
       }
       else
       {
-        return address_of_exprt(target_expr);
+        const auto result_expr = address_of_exprt(target_expr);
+        CHECK_RETURN(result_expr.type() == zero_expr.type());
+        return result_expr;
       }
     }
   }