Split dynamic objects right after they are created

There must be no code between creating dynamic objects (replace malloc)
and splitting them into instances since if the code in between changes
numbering of GOTO nodes, the split objects may have a different location
number than the original objects (which contain also a concrete object).

This may cause some trouble later, especially with the zones domain,
when it would add differences between fields of objects that can never
be allocated at the same time (have contradictory allocation guards).
Such template rows would make the invariant incomputable, yielding false
negative results.

Author: viktormalik

src/2ls/2ls_parse_options.cpp

@@ -1113,6 +1113,7 @@ bool twols_parse_optionst::process_goto_program(
     // Replace malloc
     dynamic_objects=util_make_unique<dynamic_objectst>(goto_model);
     dynamic_objects->replace_malloc(options.get_bool_option("pointer-check"));
+    dynamic_objects->generate_instances(options);
 
     // Allow recording of mallocs and memory leaks
     if(options.get_bool_option("pointer-check"))
@@ -1137,8 +1138,6 @@ bool twols_parse_optionst::process_goto_program(
       inline_main(goto_model);
     }
 
-    dynamic_objects->generate_instances(options);
-
     if(!cmdline.isset("independent-properties"))
     {
       add_assumptions_after_assertions(goto_model);