Skip to content

fix stac browser domain settings #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025
Merged

fix stac browser domain settings #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d42ea27
update gitignore
hrodmn Feb 20, 2025
f729049
clean up config
hrodmn Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,3 +170,5 @@ node_modules/
.ruff_cache/
.env-cdk
config.yaml
stac-browser/
.envrc
1 change: 0 additions & 1 deletion browser_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
module.exports = {
catalogUrl: "https://stac.eoapi.dev",
catalogTitle: "eoAPI STAC Browser",
allowExternalAccess: true, // Must be true if catalogUrl is not given
allowedDomains: [],
Expand Down
16 changes: 8 additions & 8 deletions infrastructure/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,14 @@ def validate_model(self) -> Self:
and therefore `nat_gateway_count` has to be > 0."""
)

# if (
# self.stac_browser_version is not None
# and self.stac_api_custom_domain is None
# ):
# raise ValueError(
# """If a STAC browser version is provided,
# a custom domain must be provided for the STAC API"""
# )
if (
self.stac_browser_version is not None
and self.stac_api_custom_domain is None
):
raise ValueError(
"""If a STAC browser version is provided,
a custom domain must be provided for the STAC API"""
)

if self.acm_certificate_arn is None and any(
[
Expand Down