Rename emitted variable to isInlinedSchema

desjoerd · desjoerd · commit 81df677f4048 · 2025-08-05T15:18:06.000+02:00
diff --git a/src/OpenApi/gen/XmlCommentGenerator.Emitter.cs b/src/OpenApi/gen/XmlCommentGenerator.Emitter.cs
@@ -459,10 +459,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext
                 }
             }
 
-            var isPropertyInlinedSchema = schema.Metadata is null
+            var isInlinedSchema = schema.Metadata is null
                   || !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)
                   || string.IsNullOrEmpty(schemaId as string);
-            if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
+            if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
             {
                 // Apply comments from the property
                 if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))
diff --git a/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/AddOpenApiTests.CanInterceptAddOpenApi#OpenApiXmlCommentSupport.generated.verified.cs b/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/AddOpenApiTests.CanInterceptAddOpenApi#OpenApiXmlCommentSupport.generated.verified.cs
@@ -441,10 +441,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext
                 }
             }
 
-            var isPropertyInlinedSchema = schema.Metadata is null
+            var isInlinedSchema = schema.Metadata is null
                   || !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)
                   || string.IsNullOrEmpty(schemaId as string);
-            if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
+            if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
             {
                 // Apply comments from the property
                 if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))
diff --git a/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/AdditionalTextsTests.CanHandleXmlForSchemasInAdditionalTexts#OpenApiXmlCommentSupport.generated.verified.cs b/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/AdditionalTextsTests.CanHandleXmlForSchemasInAdditionalTexts#OpenApiXmlCommentSupport.generated.verified.cs
@@ -470,10 +470,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext
                 }
             }
 
-            var isPropertyInlinedSchema = schema.Metadata is null
+            var isInlinedSchema = schema.Metadata is null
                   || !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)
                   || string.IsNullOrEmpty(schemaId as string);
-            if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
+            if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
             {
                 // Apply comments from the property
                 if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))
diff --git a/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/CompletenessTests.SupportsAllXmlTagsOnSchemas#OpenApiXmlCommentSupport.generated.verified.cs b/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/CompletenessTests.SupportsAllXmlTagsOnSchemas#OpenApiXmlCommentSupport.generated.verified.cs
@@ -562,10 +562,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext
                 }
             }
 
-            var isPropertyInlinedSchema = schema.Metadata is null
+            var isInlinedSchema = schema.Metadata is null
                   || !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)
                   || string.IsNullOrEmpty(schemaId as string);
-            if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
+            if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
             {
                 // Apply comments from the property
                 if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))
diff --git a/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/OperationTests.SupportsXmlCommentsOnOperationsFromControllers#OpenApiXmlCommentSupport.generated.verified.cs b/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/OperationTests.SupportsXmlCommentsOnOperationsFromControllers#OpenApiXmlCommentSupport.generated.verified.cs
@@ -445,10 +445,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext
                 }
             }
 
-            var isPropertyInlinedSchema = schema.Metadata is null
+            var isInlinedSchema = schema.Metadata is null
                   || !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)
                   || string.IsNullOrEmpty(schemaId as string);
-            if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
+            if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
             {
                 // Apply comments from the property
                 if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))
diff --git a/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/OperationTests.SupportsXmlCommentsOnOperationsFromMinimalApis#OpenApiXmlCommentSupport.generated.verified.cs b/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/OperationTests.SupportsXmlCommentsOnOperationsFromMinimalApis#OpenApiXmlCommentSupport.generated.verified.cs
@@ -463,10 +463,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext
                 }
             }
 
-            var isPropertyInlinedSchema = schema.Metadata is null
+            var isInlinedSchema = schema.Metadata is null
                   || !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)
                   || string.IsNullOrEmpty(schemaId as string);
-            if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
+            if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
             {
                 // Apply comments from the property
                 if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))
diff --git a/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/SchemaTests.SupportsXmlCommentsOnSchemas#OpenApiXmlCommentSupport.generated.verified.cs b/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/SchemaTests.SupportsXmlCommentsOnSchemas#OpenApiXmlCommentSupport.generated.verified.cs
@@ -479,10 +479,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext
                 }
             }
 
-            var isPropertyInlinedSchema = schema.Metadata is null
+            var isInlinedSchema = schema.Metadata is null
                   || !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)
                   || string.IsNullOrEmpty(schemaId as string);
-            if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
+            if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
             {
                 // Apply comments from the property
                 if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))
diff --git a/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/SchemaTests.XmlCommentsOnPropertiesShouldNotApplyToReferencedSchemas#OpenApiXmlCommentSupport.generated.verified.cs b/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/SchemaTests.XmlCommentsOnPropertiesShouldNotApplyToReferencedSchemas#OpenApiXmlCommentSupport.generated.verified.cs
@@ -450,10 +450,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext
                 }
             }
 
-            var isPropertyInlinedSchema = schema.Metadata is null
+            var isInlinedSchema = schema.Metadata is null
                   || !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)
                   || string.IsNullOrEmpty(schemaId as string);
-            if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
+            if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
             {
                 // Apply comments from the property
                 if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))
diff --git a/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/XmlCommentDocumentationIdTests.CanMergeXmlCommentsWithDifferentDocumentationIdFormats#OpenApiXmlCommentSupport.generated.verified.cs b/src/OpenApi/test/Microsoft.AspNetCore.OpenApi.SourceGenerators.Tests/snapshots/XmlCommentDocumentationIdTests.CanMergeXmlCommentsWithDifferentDocumentationIdFormats#OpenApiXmlCommentSupport.generated.verified.cs
@@ -442,10 +442,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext
                 }
             }
 
-            var isPropertyInlinedSchema = schema.Metadata is null
+            var isInlinedSchema = schema.Metadata is null
                   || !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)
                   || string.IsNullOrEmpty(schemaId as string);
-            if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
+            if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })
             {
                 // Apply comments from the property
                 if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))

Original file line number	Diff line number	Diff line change
`@@ -459,10 +459,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext`
`459`	`459`	`}`
`460`	`460`	`}`
`461`	`461`
`462`		`- var isPropertyInlinedSchema = schema.Metadata is null`
	`462`	`+ var isInlinedSchema = schema.Metadata is null`
`463`	`463`	`\|\| !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)`
`464`	`464`	`\|\| string.IsNullOrEmpty(schemaId as string);`
`465`		`- if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
	`465`	`+ if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
`466`	`466`	`{`
`467`	`467`	`// Apply comments from the property`
`468`	`468`	`if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))`
Original file line number	Diff line number	Diff line change
`@@ -441,10 +441,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext`
`441`	`441`	`}`
`442`	`442`	`}`
`443`	`443`
`444`		`- var isPropertyInlinedSchema = schema.Metadata is null`
	`444`	`+ var isInlinedSchema = schema.Metadata is null`
`445`	`445`	`\|\| !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)`
`446`	`446`	`\|\| string.IsNullOrEmpty(schemaId as string);`
`447`		`- if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
	`447`	`+ if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
`448`	`448`	`{`
`449`	`449`	`// Apply comments from the property`
`450`	`450`	`if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))`
Original file line number	Diff line number	Diff line change
`@@ -470,10 +470,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext`
`470`	`470`	`}`
`471`	`471`	`}`
`472`	`472`
`473`		`- var isPropertyInlinedSchema = schema.Metadata is null`
	`473`	`+ var isInlinedSchema = schema.Metadata is null`
`474`	`474`	`\|\| !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)`
`475`	`475`	`\|\| string.IsNullOrEmpty(schemaId as string);`
`476`		`- if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
	`476`	`+ if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
`477`	`477`	`{`
`478`	`478`	`// Apply comments from the property`
`479`	`479`	`if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))`
Original file line number	Diff line number	Diff line change
`@@ -562,10 +562,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext`
`562`	`562`	`}`
`563`	`563`	`}`
`564`	`564`
`565`		`- var isPropertyInlinedSchema = schema.Metadata is null`
	`565`	`+ var isInlinedSchema = schema.Metadata is null`
`566`	`566`	`\|\| !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)`
`567`	`567`	`\|\| string.IsNullOrEmpty(schemaId as string);`
`568`		`- if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
	`568`	`+ if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
`569`	`569`	`{`
`570`	`570`	`// Apply comments from the property`
`571`	`571`	`if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))`
Original file line number	Diff line number	Diff line change
`@@ -445,10 +445,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext`
`445`	`445`	`}`
`446`	`446`	`}`
`447`	`447`
`448`		`- var isPropertyInlinedSchema = schema.Metadata is null`
	`448`	`+ var isInlinedSchema = schema.Metadata is null`
`449`	`449`	`\|\| !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)`
`450`	`450`	`\|\| string.IsNullOrEmpty(schemaId as string);`
`451`		`- if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
	`451`	`+ if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
`452`	`452`	`{`
`453`	`453`	`// Apply comments from the property`
`454`	`454`	`if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))`
Original file line number	Diff line number	Diff line change
`@@ -463,10 +463,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext`
`463`	`463`	`}`
`464`	`464`	`}`
`465`	`465`
`466`		`- var isPropertyInlinedSchema = schema.Metadata is null`
	`466`	`+ var isInlinedSchema = schema.Metadata is null`
`467`	`467`	`\|\| !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)`
`468`	`468`	`\|\| string.IsNullOrEmpty(schemaId as string);`
`469`		`- if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
	`469`	`+ if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
`470`	`470`	`{`
`471`	`471`	`// Apply comments from the property`
`472`	`472`	`if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))`
Original file line number	Diff line number	Diff line change
`@@ -479,10 +479,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext`
`479`	`479`	`}`
`480`	`480`	`}`
`481`	`481`
`482`		`- var isPropertyInlinedSchema = schema.Metadata is null`
	`482`	`+ var isInlinedSchema = schema.Metadata is null`
`483`	`483`	`\|\| !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)`
`484`	`484`	`\|\| string.IsNullOrEmpty(schemaId as string);`
`485`		`- if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
	`485`	`+ if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
`486`	`486`	`{`
`487`	`487`	`// Apply comments from the property`
`488`	`488`	`if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))`
Original file line number	Diff line number	Diff line change
`@@ -450,10 +450,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext`
`450`	`450`	`}`
`451`	`451`	`}`
`452`	`452`
`453`		`- var isPropertyInlinedSchema = schema.Metadata is null`
	`453`	`+ var isInlinedSchema = schema.Metadata is null`
`454`	`454`	`\|\| !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)`
`455`	`455`	`\|\| string.IsNullOrEmpty(schemaId as string);`
`456`		`- if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
	`456`	`+ if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
`457`	`457`	`{`
`458`	`458`	`// Apply comments from the property`
`459`	`459`	`if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))`
Original file line number	Diff line number	Diff line change
`@@ -442,10 +442,10 @@ public Task TransformAsync(OpenApiSchema schema, OpenApiSchemaTransformerContext`
`442`	`442`	`}`
`443`	`443`	`}`
`444`	`444`
`445`		`- var isPropertyInlinedSchema = schema.Metadata is null`
	`445`	`+ var isInlinedSchema = schema.Metadata is null`
`446`	`446`	`\|\| !schema.Metadata.TryGetValue("x-schema-id", out var schemaId)`
`447`	`447`	`\|\| string.IsNullOrEmpty(schemaId as string);`
`448`		`- if (isPropertyInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
	`448`	`+ if (isInlinedSchema && context.JsonPropertyInfo is { AttributeProvider: PropertyInfo propertyInfo })`
`449`	`449`	`{`
`450`	`450`	`// Apply comments from the property`
`451`	`451`	`if (XmlCommentCache.Cache.TryGetValue(DocumentationCommentIdHelper.NormalizeDocId(propertyInfo.CreateDocumentationId()), out var propertyComment))`