DLPX-87560 sdb: dmesg broken for 5.15 kernels #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch replaces our hand-written implementation of dmesg which doesn't work for most vanilla kernel versions after 5.10 with the drgn helper which stays up to date more often. In order for this to work I had to change the type of our dmesg command from a Locator+PrettyPrinter to a standard command. This is not a big deal as the only reason we would ever walk and filter dmesg would be to filter the kernel logs by level. I've added this as an argument to the command. = Github Issue Tracker Automation Closes delphix#336
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #340 +/- ##
===========================================
- Coverage 85.18% 85.18% -0.01%
===========================================
Files 67 67
Lines 3084 3077 -7
===========================================
- Hits 2627 2621 -6
+ Misses 457 456 -1
|
prakashsurya
approved these changes
Aug 22, 2023
ahrens
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces our hand-written implementation of dmesg which doesn't work for most vanilla kernel versions after 5.10 with the drgn helper which stays up to date more often.
In order for this to work I had to change the type of our dmesg command from a Locator+PrettyPrinter to a standard command. This is not a big deal as the only reason we would ever walk and filter dmesg would be to filter the kernel logs by level. I've added this as an argument to the command.
= Github Issue Tracker Automation
Closes #336