Skip to content

Commit f95d5bf

Browse files
Carmichael561davem330
authored andcommitted
lmc: Use memdup_user() as a cleanup
Fix coccicheck warning which recommends to use memdup_user(): drivers/net/wan/lmc/lmc_main.c:497:27-34: WARNING opportunity for memdup_user Generated by: scripts/coccinelle/memdup_user/memdup_user.cocci Signed-off-by: Vasyl Gomonovych <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent dea521a commit f95d5bf

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

drivers/net/wan/lmc/lmc_main.c

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -494,18 +494,11 @@ int lmc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/
494494
break;
495495
}
496496

497-
data = kmalloc(xc.len, GFP_KERNEL);
498-
if (!data) {
499-
ret = -ENOMEM;
497+
data = memdup_user(xc.data, xc.len);
498+
if (IS_ERR(data)) {
499+
ret = PTR_ERR(data);
500500
break;
501501
}
502-
503-
if(copy_from_user(data, xc.data, xc.len))
504-
{
505-
kfree(data);
506-
ret = -ENOMEM;
507-
break;
508-
}
509502

510503
printk("%s: Starting load of data Len: %d at 0x%p == 0x%p\n", dev->name, xc.len, xc.data, data);
511504

0 commit comments

Comments
 (0)