Skip to content

Commit f20b4f2

Browse files
Colin Ian KingJarkko Sakkinen
authored andcommitted
tpm: st33zp24: remove redundant null check on chip
Currently chip is being dereferenced by the call to dev_get_drvdata before it is being null checked, however, chip can never be null, so this check is misleading and redundant. Remove it. Detected by CoverityScan, CID#1357806 ("Dereference before null check") Signed-off-by: Colin Ian King <[email protected]> Reviewed-by: Jarkko Sakkinen <[email protected]> Signed-off-by: Jarkko Sakkinen <[email protected]>
1 parent 9298075 commit f20b4f2

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/char/tpm/st33zp24/st33zp24.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,8 +373,6 @@ static int st33zp24_send(struct tpm_chip *chip, unsigned char *buf,
373373
int ret;
374374
u8 data;
375375

376-
if (!chip)
377-
return -EBUSY;
378376
if (len < TPM_HEADER_SIZE)
379377
return -EBUSY;
380378

0 commit comments

Comments
 (0)