Skip to content

Commit eaf9254

Browse files
ebiggersDarrick J. Wong
authored andcommitted
xfs: remove a stale comment from xfs_file_aio_write_checks()
The comment in xfs_file_aio_write_checks() about calling file_modified() after dropping the ilock doesn't make sense, because the code that unconditionally acquires and drops the ilock was removed by commit 467f789 ("xfs: reduce ilock hold times in xfs_file_aio_write_checks"). Remove this outdated comment. Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Eric Biggers <[email protected]> Reviewed-by: Darrick J. Wong <[email protected]> Signed-off-by: Darrick J. Wong <[email protected]>
1 parent 3015196 commit eaf9254

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

fs/xfs/xfs_file.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -389,12 +389,6 @@ xfs_file_aio_write_checks(
389389
} else
390390
spin_unlock(&ip->i_flags_lock);
391391

392-
/*
393-
* Updating the timestamps will grab the ilock again from
394-
* xfs_fs_dirty_inode, so we have to call it after dropping the
395-
* lock above. Eventually we should look into a way to avoid
396-
* the pointless lock roundtrip.
397-
*/
398392
return file_modified(file);
399393
}
400394

0 commit comments

Comments
 (0)