Skip to content

Commit e64edfc

Browse files
suryasaimadhuIngo Molnar
authored andcommitted
x86/mce: Rename mce_log to mce_log_buffer
It is confusing when staring at "struct mce_log mcelog" and then there's also a function called mce_log(). So call the buffer what it is. No functionality change. Signed-off-by: Borislav Petkov <[email protected]> Cc: Linus Torvalds <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: linux-edac <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Ingo Molnar <[email protected]>
1 parent fe3ed20 commit e64edfc

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

arch/x86/include/asm/mce.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@
128128
* debugging tools. Each entry is only valid when its finished flag
129129
* is set.
130130
*/
131-
struct mce_log {
131+
struct mce_log_buffer {
132132
char signature[12]; /* "MACHINECHECK" */
133133
unsigned len; /* = MCE_LOG_LEN */
134134
unsigned next;

arch/x86/kernel/cpu/mcheck/mce.c

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ EXPORT_PER_CPU_SYMBOL_GPL(injectm);
152152
* separate MCEs from kernel messages to avoid bogus bug reports.
153153
*/
154154

155-
static struct mce_log mcelog = {
155+
static struct mce_log_buffer mcelog_buf = {
156156
.signature = MCE_LOG_SIGNATURE,
157157
.len = MCE_LOG_LEN,
158158
.recordlen = sizeof(struct mce),
@@ -170,7 +170,7 @@ void mce_log(struct mce *m)
170170

171171
wmb();
172172
for (;;) {
173-
entry = mce_log_get_idx_check(mcelog.next);
173+
entry = mce_log_get_idx_check(mcelog_buf.next);
174174
for (;;) {
175175

176176
/*
@@ -180,24 +180,24 @@ void mce_log(struct mce *m)
180180
*/
181181
if (entry >= MCE_LOG_LEN) {
182182
set_bit(MCE_OVERFLOW,
183-
(unsigned long *)&mcelog.flags);
183+
(unsigned long *)&mcelog_buf.flags);
184184
return;
185185
}
186186
/* Old left over entry. Skip: */
187-
if (mcelog.entry[entry].finished) {
187+
if (mcelog_buf.entry[entry].finished) {
188188
entry++;
189189
continue;
190190
}
191191
break;
192192
}
193193
smp_rmb();
194194
next = entry + 1;
195-
if (cmpxchg(&mcelog.next, entry, next) == entry)
195+
if (cmpxchg(&mcelog_buf.next, entry, next) == entry)
196196
break;
197197
}
198-
memcpy(mcelog.entry + entry, m, sizeof(struct mce));
198+
memcpy(mcelog_buf.entry + entry, m, sizeof(struct mce));
199199
wmb();
200-
mcelog.entry[entry].finished = 1;
200+
mcelog_buf.entry[entry].finished = 1;
201201
wmb();
202202

203203
set_bit(0, &mce_need_notify);
@@ -1958,7 +1958,7 @@ static ssize_t mce_chrdev_read(struct file *filp, char __user *ubuf,
19581958
goto out;
19591959
}
19601960

1961-
next = mce_log_get_idx_check(mcelog.next);
1961+
next = mce_log_get_idx_check(mcelog_buf.next);
19621962

19631963
/* Only supports full reads right now */
19641964
err = -EINVAL;
@@ -1970,7 +1970,7 @@ static ssize_t mce_chrdev_read(struct file *filp, char __user *ubuf,
19701970
do {
19711971
for (i = prev; i < next; i++) {
19721972
unsigned long start = jiffies;
1973-
struct mce *m = &mcelog.entry[i];
1973+
struct mce *m = &mcelog_buf.entry[i];
19741974

19751975
while (!m->finished) {
19761976
if (time_after_eq(jiffies, start + 2)) {
@@ -1986,10 +1986,10 @@ static ssize_t mce_chrdev_read(struct file *filp, char __user *ubuf,
19861986
;
19871987
}
19881988

1989-
memset(mcelog.entry + prev, 0,
1989+
memset(mcelog_buf.entry + prev, 0,
19901990
(next - prev) * sizeof(struct mce));
19911991
prev = next;
1992-
next = cmpxchg(&mcelog.next, prev, 0);
1992+
next = cmpxchg(&mcelog_buf.next, prev, 0);
19931993
} while (next != prev);
19941994

19951995
synchronize_sched();
@@ -2001,7 +2001,7 @@ static ssize_t mce_chrdev_read(struct file *filp, char __user *ubuf,
20012001
on_each_cpu(collect_tscs, cpu_tsc, 1);
20022002

20032003
for (i = next; i < MCE_LOG_LEN; i++) {
2004-
struct mce *m = &mcelog.entry[i];
2004+
struct mce *m = &mcelog_buf.entry[i];
20052005

20062006
if (m->finished && m->tsc < cpu_tsc[m->cpu]) {
20072007
err |= copy_to_user(buf, m, sizeof(*m));
@@ -2024,7 +2024,7 @@ static ssize_t mce_chrdev_read(struct file *filp, char __user *ubuf,
20242024
static unsigned int mce_chrdev_poll(struct file *file, poll_table *wait)
20252025
{
20262026
poll_wait(file, &mce_chrdev_wait, wait);
2027-
if (READ_ONCE(mcelog.next))
2027+
if (READ_ONCE(mcelog_buf.next))
20282028
return POLLIN | POLLRDNORM;
20292029
if (!mce_apei_read_done && apei_check_mce())
20302030
return POLLIN | POLLRDNORM;
@@ -2048,8 +2048,8 @@ static long mce_chrdev_ioctl(struct file *f, unsigned int cmd,
20482048
unsigned flags;
20492049

20502050
do {
2051-
flags = mcelog.flags;
2052-
} while (cmpxchg(&mcelog.flags, flags, 0) != flags);
2051+
flags = mcelog_buf.flags;
2052+
} while (cmpxchg(&mcelog_buf.flags, flags, 0) != flags);
20532053

20542054
return put_user(flags, p);
20552055
}

0 commit comments

Comments
 (0)