Skip to content

Commit dc30c6e

Browse files
committed
drm/xe: Label RING_CONTEXT_CONTROL as masked
RING_CONTEXT_CONTROL is a masked register. v2: Also clean up setting register value (Lucas) Reviewed-by: Matt Roper <[email protected]> Reviewed-by: Lucas De Marchi <[email protected]> Signed-off-by: Ashutosh Dixit <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 335ad80 commit dc30c6e

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

drivers/gpu/drm/xe/regs/xe_engine_regs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@
122122
#define RING_EXECLIST_STATUS_LO(base) XE_REG((base) + 0x234)
123123
#define RING_EXECLIST_STATUS_HI(base) XE_REG((base) + 0x234 + 4)
124124

125-
#define RING_CONTEXT_CONTROL(base) XE_REG((base) + 0x244)
125+
#define RING_CONTEXT_CONTROL(base) XE_REG((base) + 0x244, XE_REG_OPTION_MASKED)
126126
#define CTX_CTRL_INHIBIT_SYN_CTX_SWITCH REG_BIT(3)
127127
#define CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT REG_BIT(0)
128128

drivers/gpu/drm/xe/xe_lrc.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -543,9 +543,8 @@ static const u8 *reg_offsets(struct xe_device *xe, enum xe_engine_class class)
543543

544544
static void set_context_control(u32 *regs, struct xe_hw_engine *hwe)
545545
{
546-
regs[CTX_CONTEXT_CONTROL] = _MASKED_BIT_ENABLE(CTX_CTRL_INHIBIT_SYN_CTX_SWITCH) |
547-
_MASKED_BIT_DISABLE(CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT) |
548-
CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT;
546+
regs[CTX_CONTEXT_CONTROL] = _MASKED_BIT_ENABLE(CTX_CTRL_INHIBIT_SYN_CTX_SWITCH |
547+
CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT);
549548

550549
/* TODO: Timestamp */
551550
}

0 commit comments

Comments
 (0)