Skip to content

Commit db1b5cc

Browse files
committed
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid
Pull HID fixes from Jiri Kosina: - revert of a commit to magicmouse driver that regressess certain devices, from Daniel Stone - quirk for a specific Dell mouse, from Sebastian Parschauer * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid: Revert "HID: magicmouse: Set multi-touch keybits for Magic Mouse" HID: Add quirk for Dell PIXART OEM mouse
2 parents dcba710 + 900a88e commit db1b5cc

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

drivers/hid/hid-ids.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,9 @@
319319
#define USB_VENDOR_ID_DELCOM 0x0fc5
320320
#define USB_DEVICE_ID_DELCOM_VISUAL_IND 0xb080
321321

322+
#define USB_VENDOR_ID_DELL 0x413c
323+
#define USB_DEVICE_ID_DELL_PIXART_USB_OPTICAL_MOUSE 0x301a
324+
322325
#define USB_VENDOR_ID_DELORME 0x1163
323326
#define USB_DEVICE_ID_DELORME_EARTHMATE 0x0100
324327
#define USB_DEVICE_ID_DELORME_EM_LT20 0x0200

drivers/hid/hid-magicmouse.c

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,6 @@ static int magicmouse_raw_event(struct hid_device *hdev,
349349

350350
if (input->id.product == USB_DEVICE_ID_APPLE_MAGICMOUSE) {
351351
magicmouse_emit_buttons(msc, clicks & 3);
352-
input_mt_report_pointer_emulation(input, true);
353352
input_report_rel(input, REL_X, x);
354353
input_report_rel(input, REL_Y, y);
355354
} else { /* USB_DEVICE_ID_APPLE_MAGICTRACKPAD */
@@ -389,16 +388,16 @@ static int magicmouse_setup_input(struct input_dev *input, struct hid_device *hd
389388
__clear_bit(BTN_RIGHT, input->keybit);
390389
__clear_bit(BTN_MIDDLE, input->keybit);
391390
__set_bit(BTN_MOUSE, input->keybit);
391+
__set_bit(BTN_TOOL_FINGER, input->keybit);
392+
__set_bit(BTN_TOOL_DOUBLETAP, input->keybit);
393+
__set_bit(BTN_TOOL_TRIPLETAP, input->keybit);
394+
__set_bit(BTN_TOOL_QUADTAP, input->keybit);
395+
__set_bit(BTN_TOOL_QUINTTAP, input->keybit);
396+
__set_bit(BTN_TOUCH, input->keybit);
397+
__set_bit(INPUT_PROP_POINTER, input->propbit);
392398
__set_bit(INPUT_PROP_BUTTONPAD, input->propbit);
393399
}
394400

395-
__set_bit(BTN_TOOL_FINGER, input->keybit);
396-
__set_bit(BTN_TOOL_DOUBLETAP, input->keybit);
397-
__set_bit(BTN_TOOL_TRIPLETAP, input->keybit);
398-
__set_bit(BTN_TOOL_QUADTAP, input->keybit);
399-
__set_bit(BTN_TOOL_QUINTTAP, input->keybit);
400-
__set_bit(BTN_TOUCH, input->keybit);
401-
__set_bit(INPUT_PROP_POINTER, input->propbit);
402401

403402
__set_bit(EV_ABS, input->evbit);
404403

drivers/hid/usbhid/hid-quirks.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ static const struct hid_blacklist {
8585
{ USB_VENDOR_ID_CORSAIR, USB_DEVICE_ID_CORSAIR_K65RGB_RAPIDFIRE, HID_QUIRK_NO_INIT_REPORTS | HID_QUIRK_ALWAYS_POLL },
8686
{ USB_VENDOR_ID_CORSAIR, USB_DEVICE_ID_CORSAIR_SCIMITAR_PRO_RGB, HID_QUIRK_NO_INIT_REPORTS | HID_QUIRK_ALWAYS_POLL },
8787
{ USB_VENDOR_ID_CREATIVELABS, USB_DEVICE_ID_CREATIVE_SB_OMNI_SURROUND_51, HID_QUIRK_NOGET },
88+
{ USB_VENDOR_ID_DELL, USB_DEVICE_ID_DELL_PIXART_USB_OPTICAL_MOUSE, HID_QUIRK_ALWAYS_POLL },
8889
{ USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET },
8990
{ USB_VENDOR_ID_DRAGONRISE, USB_DEVICE_ID_DRAGONRISE_WIIU, HID_QUIRK_MULTI_INPUT },
9091
{ USB_VENDOR_ID_DRAGONRISE, USB_DEVICE_ID_DRAGONRISE_PS3, HID_QUIRK_MULTI_INPUT },

0 commit comments

Comments
 (0)