Skip to content

Commit d1254a8

Browse files
Christoph Hellwigaxboe
authored andcommitted
block: remove support for delayed queue registrations
Now that device mapper has been changed to register the disk once it is fully ready all this code is unused. Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: Mike Snitzer <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent 89f871a commit d1254a8

File tree

3 files changed

+7
-29
lines changed

3 files changed

+7
-29
lines changed

block/elevator.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -705,7 +705,6 @@ void elevator_init_mq(struct request_queue *q)
705705
elevator_put(e);
706706
}
707707
}
708-
EXPORT_SYMBOL_GPL(elevator_init_mq); /* only for dm-rq */
709708

710709
/*
711710
* switch to new_e io scheduler. be careful not to introduce deadlocks -

block/genhd.c

Lines changed: 7 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -475,20 +475,20 @@ static void register_disk(struct device *parent, struct gendisk *disk,
475475
}
476476

477477
/**
478-
* __device_add_disk - add disk information to kernel list
478+
* device_add_disk - add disk information to kernel list
479479
* @parent: parent device for the disk
480480
* @disk: per-device partitioning information
481481
* @groups: Additional per-device sysfs groups
482-
* @register_queue: register the queue if set to true
483482
*
484483
* This function registers the partitioning information in @disk
485484
* with the kernel.
486485
*
487486
* FIXME: error handling
488487
*/
489-
static void __device_add_disk(struct device *parent, struct gendisk *disk,
490-
const struct attribute_group **groups,
491-
bool register_queue)
488+
489+
void device_add_disk(struct device *parent, struct gendisk *disk,
490+
const struct attribute_group **groups)
491+
492492
{
493493
int ret;
494494

@@ -498,8 +498,7 @@ static void __device_add_disk(struct device *parent, struct gendisk *disk,
498498
* elevator if one is needed, that is, for devices requesting queue
499499
* registration.
500500
*/
501-
if (register_queue)
502-
elevator_init_mq(disk->queue);
501+
elevator_init_mq(disk->queue);
503502

504503
/*
505504
* If the driver provides an explicit major number it also must provide
@@ -553,8 +552,7 @@ static void __device_add_disk(struct device *parent, struct gendisk *disk,
553552
bdev_add(disk->part0, dev->devt);
554553
}
555554
register_disk(parent, disk, groups);
556-
if (register_queue)
557-
blk_register_queue(disk);
555+
blk_register_queue(disk);
558556

559557
/*
560558
* Take an extra ref on queue which will be put on disk_release()
@@ -568,21 +566,8 @@ static void __device_add_disk(struct device *parent, struct gendisk *disk,
568566
disk_add_events(disk);
569567
blk_integrity_add(disk);
570568
}
571-
572-
void device_add_disk(struct device *parent, struct gendisk *disk,
573-
const struct attribute_group **groups)
574-
575-
{
576-
__device_add_disk(parent, disk, groups, true);
577-
}
578569
EXPORT_SYMBOL(device_add_disk);
579570

580-
void device_add_disk_no_queue_reg(struct device *parent, struct gendisk *disk)
581-
{
582-
__device_add_disk(parent, disk, NULL, false);
583-
}
584-
EXPORT_SYMBOL(device_add_disk_no_queue_reg);
585-
586571
/**
587572
* del_gendisk - remove the gendisk
588573
* @disk: the struct gendisk to remove

include/linux/genhd.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -219,12 +219,6 @@ static inline void add_disk(struct gendisk *disk)
219219
{
220220
device_add_disk(NULL, disk, NULL);
221221
}
222-
extern void device_add_disk_no_queue_reg(struct device *parent, struct gendisk *disk);
223-
static inline void add_disk_no_queue_reg(struct gendisk *disk)
224-
{
225-
device_add_disk_no_queue_reg(NULL, disk);
226-
}
227-
228222
extern void del_gendisk(struct gendisk *gp);
229223

230224
void set_disk_ro(struct gendisk *disk, bool read_only);

0 commit comments

Comments
 (0)