sysfs: fix simple_return.cocci warnings

kbuild test robot · cschaufler · commit ca70d27e445f · 2015-07-22T12:31:40.000-07:00
security/smack/smackfs.c:2251:1-4: WARNING: end returns can be
simpified and declaration on line 2250 can be dropped

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.

Generated by: scripts/coccinelle/misc/simple_return.cocci

Signed-off-by: Fengguang Wu &lt;fengguang.wu@intel.com&gt;
Acked-by: Serge Hallyn &lt;serge.hallyn@canonical.com&gt;
Acked-by: Casey Schaufler &lt;casey@schaufler-ca.com&gt;
diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
@@ -2320,11 +2320,7 @@ static const struct file_operations smk_revoke_subj_ops = {
  */
 static int smk_init_sysfs(void)
 {
-	int err;
-	err = sysfs_create_mount_point(fs_kobj, "smackfs");
-	if (err)
-		return err;
-	return 0;
+	return sysfs_create_mount_point(fs_kobj, "smackfs");
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -2320,11 +2320,7 @@ static const struct file_operations smk_revoke_subj_ops = {`
`2320`	`2320`	`*/`
`2321`	`2321`	`static int smk_init_sysfs(void)`
`2322`	`2322`	`{`
`2323`		`- int err;`
`2324`		`- err = sysfs_create_mount_point(fs_kobj, "smackfs");`
`2325`		`- if (err)`
`2326`		`- return err;`
`2327`		`- return 0;`
	`2323`	`+ return sysfs_create_mount_point(fs_kobj, "smackfs");`
`2328`	`2324`	`}`
`2329`	`2325`
`2330`	`2326`	`/**`