Skip to content

Commit c5e453f

Browse files
Yang Guanggregkh
authored andcommitted
serial: 8250_aspeed_vuart: replace snprintf with sysfs_emit
coccinelle report: ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16: WARNING: use scnprintf or sprintf ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16: WARNING: use scnprintf or sprintf ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16: WARNING: use scnprintf or sprintf Use sysfs_emit instead of scnprintf or sprintf makes more sense. Reported-by: Zeal Robot <[email protected]> Signed-off-by: Yang Guang <[email protected]> Signed-off-by: David Yang <[email protected]> Link: https://lore.kernel.org/r/fed40753603dac4d14b17970c88e6f5f936348c1.1644541843.git.yang.guang5@zte.com.cn Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 6ba6351 commit c5e453f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/tty/serial/8250/8250_aspeed_vuart.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ static ssize_t lpc_address_show(struct device *dev,
8282
addr = (aspeed_vuart_readb(vuart, ASPEED_VUART_ADDRH) << 8) |
8383
(aspeed_vuart_readb(vuart, ASPEED_VUART_ADDRL));
8484

85-
return snprintf(buf, PAGE_SIZE - 1, "0x%x\n", addr);
85+
return sysfs_emit(buf, "0x%x\n", addr);
8686
}
8787

8888
static int aspeed_vuart_set_lpc_address(struct aspeed_vuart *vuart, u32 addr)
@@ -124,7 +124,7 @@ static ssize_t sirq_show(struct device *dev,
124124
reg &= ASPEED_VUART_GCRB_HOST_SIRQ_MASK;
125125
reg >>= ASPEED_VUART_GCRB_HOST_SIRQ_SHIFT;
126126

127-
return snprintf(buf, PAGE_SIZE - 1, "%u\n", reg);
127+
return sysfs_emit(buf, "%u\n", reg);
128128
}
129129

130130
static int aspeed_vuart_set_sirq(struct aspeed_vuart *vuart, u32 sirq)
@@ -171,7 +171,7 @@ static ssize_t sirq_polarity_show(struct device *dev,
171171
reg = aspeed_vuart_readb(vuart, ASPEED_VUART_GCRA);
172172
reg &= ASPEED_VUART_GCRA_HOST_SIRQ_POLARITY;
173173

174-
return snprintf(buf, PAGE_SIZE - 1, "%u\n", reg ? 1 : 0);
174+
return sysfs_emit(buf, "%u\n", reg ? 1 : 0);
175175
}
176176

177177
static void aspeed_vuart_set_sirq_polarity(struct aspeed_vuart *vuart,

0 commit comments

Comments
 (0)