Skip to content

Commit c19d034

Browse files
maurorodriguesJeff Kirsher
authored andcommitted
i40e: Remove EMPR traces from debugfs facility
Since commit '5098850c9b9b ("i40e/i40evf: i40e_register.h updates")' it is no longer possible to trigger an EMP Reset from debugfs, but it's possible to request it either way, to end up with a bad reset request: echo empr > /sys/kernel/debug/i40e/0002\:01\:00.1/command i40e 0002:01:00.1: debugfs: forcing EMPR i40e 0002:01:00.1: bad reset request 0x00010000 So let's remove this piece of code and show the available valid commands as it is when any invalid command is issued. Signed-off-by: "Mauro S. M. Rodrigues" <[email protected]> Tested-by: Andrew Bowers <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent 54579ca commit c19d034

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

drivers/net/ethernet/intel/i40e/i40e.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ enum i40e_state_t {
131131
__I40E_PF_RESET_REQUESTED,
132132
__I40E_CORE_RESET_REQUESTED,
133133
__I40E_GLOBAL_RESET_REQUESTED,
134-
__I40E_EMP_RESET_REQUESTED,
135134
__I40E_EMP_RESET_INTR_RECEIVED,
136135
__I40E_SUSPENDED,
137136
__I40E_PTP_TX_IN_PROGRESS,

drivers/net/ethernet/intel/i40e/i40e_debugfs.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1125,10 +1125,6 @@ static ssize_t i40e_dbg_command_write(struct file *filp,
11251125
dev_info(&pf->pdev->dev, "debugfs: forcing GlobR\n");
11261126
i40e_do_reset_safe(pf, BIT(__I40E_GLOBAL_RESET_REQUESTED));
11271127

1128-
} else if (strncmp(cmd_buf, "empr", 4) == 0) {
1129-
dev_info(&pf->pdev->dev, "debugfs: forcing EMPR\n");
1130-
i40e_do_reset_safe(pf, BIT(__I40E_EMP_RESET_REQUESTED));
1131-
11321128
} else if (strncmp(cmd_buf, "read", 4) == 0) {
11331129
u32 address;
11341130
u32 value;

0 commit comments

Comments
 (0)