Skip to content

Commit ba9ce77

Browse files
Gao Xianggregkh
authored andcommitted
staging: erofs: fix `trace_erofs_readpage' position
`trace_erofs_readpage' was designed for .readpage() interface hook in order to trace the detailed synchronized read rather than the internal implementation `z_erofs_do_read_page' which both .readpage() and .readpages() use. It seems the tracepoint was placed to a wrong place by mistake and it should be moved to the right place. Fixes: 284db12 ("staging: erofs: add trace points for reading zipped data") Reviewed-by: Chen Gong <[email protected]> Reviewed-by: Chao Yu <[email protected]> Signed-off-by: Gao Xiang <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 9e3bc2b commit ba9ce77

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/staging/erofs/unzip_vle.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -598,8 +598,6 @@ static int z_erofs_do_read_page(struct z_erofs_vle_frontend *fe,
598598
unsigned int cur, end, spiltted, index;
599599
int err = 0;
600600

601-
trace_erofs_readpage(page, false);
602-
603601
/* register locked file pages as online pages in pack */
604602
z_erofs_onlinepage_init(page);
605603

@@ -1288,6 +1286,8 @@ static int z_erofs_vle_normalaccess_readpage(struct file *file,
12881286
int err;
12891287
LIST_HEAD(pagepool);
12901288

1289+
trace_erofs_readpage(page, false);
1290+
12911291
#if (EROFS_FS_ZIP_CACHE_LVL >= 2)
12921292
f.cachedzone_la = (erofs_off_t)page->index << PAGE_SHIFT;
12931293
#endif

0 commit comments

Comments
 (0)