Skip to content

Commit b7c31cc

Browse files
lunnkuba-moo
authored andcommitted
net: phy-c45: Fix genphy_c45_ethtool_set_eee description
The text has been cut/paste from genphy_c45_ethtool_get_eee but not changed to reflect it performs set. Additionally, extend the comment. This function implements the logic that eee_enabled has global control over EEE. When eee_enabled is false, no link modes will be advertised, and as a result, the MAC should not transmit LPI. Signed-off-by: Andrew Lunn <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 634236b commit b7c31cc

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

drivers/net/phy/phy-c45.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1425,12 +1425,15 @@ int genphy_c45_ethtool_get_eee(struct phy_device *phydev,
14251425
EXPORT_SYMBOL(genphy_c45_ethtool_get_eee);
14261426

14271427
/**
1428-
* genphy_c45_ethtool_set_eee - get EEE supported and status
1428+
* genphy_c45_ethtool_set_eee - set EEE supported and status
14291429
* @phydev: target phy_device struct
14301430
* @data: ethtool_eee data
14311431
*
1432-
* Description: it reportes the Supported/Advertisement/LP Advertisement
1433-
* capabilities.
1432+
* Description: sets the Supported/Advertisement/LP Advertisement
1433+
* capabilities. If eee_enabled is false, no links modes are
1434+
* advertised, but the previously advertised link modes are
1435+
* retained. This allows EEE to be enabled/disabled in a
1436+
* non-destructive way.
14341437
*/
14351438
int genphy_c45_ethtool_set_eee(struct phy_device *phydev,
14361439
struct ethtool_eee *data)

0 commit comments

Comments
 (0)