Skip to content

Commit ad0376e

Browse files
committed
Merge tag 'edac_for_4.11_2' of git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp
Pull EDAC updates from Borislav Petkov: "A new EDAC driver for the Pondicherry2 memory controller IP found in the Intel Apollo Lake platform and the Denverton microserver. Plus small fixlets. Normally I had this queued for 4.12 but Tony requested for the pnd2_edac driver to possibly land in 4.11 therefore I'm sending it to you now. It is a driver for new hardware which people don't have yet so it shouldn't cause any regressions. The couple of patches ontop of it show that Qiuxu actually did test it on the hardware he has access to :)" * tag 'edac_for_4.11_2' of git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp: EDAC, pnd2_edac: Fix reported DIMM number EDAC, pnd2_edac: Fix !EDAC_DEBUG build EDAC: Select DEBUG_FS EDAC, pnd2_edac: Add new EDAC driver for Intel SoC platforms EDAC, i5000, i5400: Fix use of MTR_DRAM_WIDTH macro EDAC, xgene: Fix wrongly spelled "procesing"
2 parents 85f91d5 + 819f60f commit ad0376e

File tree

8 files changed

+1869
-4
lines changed

8 files changed

+1869
-4
lines changed

MAINTAINERS

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4775,6 +4775,12 @@ L: [email protected]
47754775
S: Maintained
47764776
F: drivers/edac/mpc85xx_edac.[ch]
47774777

4778+
EDAC-PND2
4779+
M: Tony Luck <[email protected]>
4780+
4781+
S: Maintained
4782+
F: drivers/edac/pnd2_edac.[ch]
4783+
47784784
EDAC-PASEMI
47794785
M: Egor Martovetsky <[email protected]>
47804786

drivers/edac/Kconfig

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ config EDAC_LEGACY_SYSFS
4343

4444
config EDAC_DEBUG
4545
bool "Debugging"
46+
select DEBUG_FS
4647
help
4748
This turns on debugging information for the entire EDAC subsystem.
4849
You do so by inserting edac_module with "edac_debug_level=x." Valid
@@ -259,6 +260,15 @@ config EDAC_SKX
259260
Support for error detection and correction the Intel
260261
Skylake server Integrated Memory Controllers.
261262

263+
config EDAC_PND2
264+
tristate "Intel Pondicherry2"
265+
depends on EDAC_MM_EDAC && PCI && X86_64 && X86_MCE_INTEL
266+
help
267+
Support for error detection and correction on the Intel
268+
Pondicherry2 Integrated Memory Controller. This SoC IP is
269+
first used on the Apollo Lake platform and Denverton
270+
micro-server but may appear on others in the future.
271+
262272
config EDAC_MPC85XX
263273
tristate "Freescale MPC83xx / MPC85xx"
264274
depends on EDAC_MM_EDAC && FSL_SOC

drivers/edac/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ obj-$(CONFIG_EDAC_I7300) += i7300_edac.o
3232
obj-$(CONFIG_EDAC_I7CORE) += i7core_edac.o
3333
obj-$(CONFIG_EDAC_SBRIDGE) += sb_edac.o
3434
obj-$(CONFIG_EDAC_SKX) += skx_edac.o
35+
obj-$(CONFIG_EDAC_PND2) += pnd2_edac.o
3536
obj-$(CONFIG_EDAC_E7XXX) += e7xxx_edac.o
3637
obj-$(CONFIG_EDAC_E752X) += e752x_edac.o
3738
obj-$(CONFIG_EDAC_I82443BXGX) += i82443bxgx_edac.o

drivers/edac/i5000_edac.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1293,7 +1293,7 @@ static int i5000_init_csrows(struct mem_ctl_info *mci)
12931293
dimm->mtype = MEM_FB_DDR2;
12941294

12951295
/* ask what device type on this row */
1296-
if (MTR_DRAM_WIDTH(mtr))
1296+
if (MTR_DRAM_WIDTH(mtr) == 8)
12971297
dimm->dtype = DEV_X8;
12981298
else
12991299
dimm->dtype = DEV_X4;

drivers/edac/i5400_edac.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1207,13 +1207,14 @@ static int i5400_init_dimms(struct mem_ctl_info *mci)
12071207

12081208
dimm->nr_pages = size_mb << 8;
12091209
dimm->grain = 8;
1210-
dimm->dtype = MTR_DRAM_WIDTH(mtr) ? DEV_X8 : DEV_X4;
1210+
dimm->dtype = MTR_DRAM_WIDTH(mtr) == 8 ?
1211+
DEV_X8 : DEV_X4;
12111212
dimm->mtype = MEM_FB_DDR2;
12121213
/*
12131214
* The eccc mechanism is SDDC (aka SECC), with
12141215
* is similar to Chipkill.
12151216
*/
1216-
dimm->edac_mode = MTR_DRAM_WIDTH(mtr) ?
1217+
dimm->edac_mode = MTR_DRAM_WIDTH(mtr) == 8 ?
12171218
EDAC_S8ECD8ED : EDAC_S4ECD4ED;
12181219
ndimms++;
12191220
}

0 commit comments

Comments
 (0)