Skip to content

Commit ac6639c

Browse files
julianwiedmannVasily Gorbik
authored andcommitted
s390/qdio: don't touch the dsci in tiqdio_add_input_queues()
Current code sets the dsci to 0x00000080. Which doesn't make any sense, as the indicator area is located in the _left-most_ byte. Worse: if the dsci is the _shared_ indicator, this potentially clears the indication of activity for a _different_ device. tiqdio_thinint_handler() will then have no reason to call that device's IRQ handler, and the device ends up stalling. Fixes: d0c9d4a ("[S390] qdio: set correct bit in dsci") Cc: <[email protected]> Signed-off-by: Julian Wiedmann <[email protected]> Signed-off-by: Vasily Gorbik <[email protected]>
1 parent e54e478 commit ac6639c

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/s390/cio/qdio_thinint.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ void tiqdio_add_input_queues(struct qdio_irq *irq_ptr)
7979
mutex_lock(&tiq_list_lock);
8080
list_add_rcu(&irq_ptr->input_qs[0]->entry, &tiq_list);
8181
mutex_unlock(&tiq_list_lock);
82-
xchg(irq_ptr->dsci, 1 << 7);
8382
}
8483

8584
void tiqdio_remove_input_queues(struct qdio_irq *irq_ptr)

0 commit comments

Comments
 (0)