Skip to content

Commit ac13d6d

Browse files
Rick Farringtondavem330
authored andcommitted
liquidio: fix hang when re-binding VF host drv after running DPDK VF driver
When configuring SLI_PKTn_OUTPUT_CONTROL, VF driver was assuming that IPTR mode was disabled by reset, which was not true. Since DPDK driver had set IPTR mode previously, the VF driver (which uses buf-ptr-only mode) was not properly handling DROQ packets (i.e. it saw zero-length packets). This represented an invalid hardware configuration which the driver could not handle. Signed-off-by: Rick Farrington <[email protected]> Signed-off-by: Felix Manlunas <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 7e2bc7f commit ac13d6d

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -493,6 +493,9 @@ static void cn23xx_pf_setup_global_output_regs(struct octeon_device *oct)
493493
for (q_no = srn; q_no < ern; q_no++) {
494494
reg_val = octeon_read_csr(oct, CN23XX_SLI_OQ_PKT_CONTROL(q_no));
495495

496+
/* clear IPTR */
497+
reg_val &= ~CN23XX_PKT_OUTPUT_CTL_IPTR;
498+
496499
/* set DPTR */
497500
reg_val |= CN23XX_PKT_OUTPUT_CTL_DPTR;
498501

drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,9 @@ static void cn23xx_vf_setup_global_output_regs(struct octeon_device *oct)
165165
reg_val =
166166
octeon_read_csr(oct, CN23XX_VF_SLI_OQ_PKT_CONTROL(q_no));
167167

168+
/* clear IPTR */
169+
reg_val &= ~CN23XX_PKT_OUTPUT_CTL_IPTR;
170+
168171
/* set DPTR */
169172
reg_val |= CN23XX_PKT_OUTPUT_CTL_DPTR;
170173

0 commit comments

Comments
 (0)