Skip to content

Commit aa3a0c8

Browse files
edumazetdavem330
authored andcommitted
tcp: get_openreq[46]() changes
When request sockets are no longer in a per listener hash table but on regular TCP ehash, we need to access listener uid through req->rsk_listener get_openreq6() also gets a const for its request socket argument. Signed-off-by: Eric Dumazet <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 9cfd086 commit aa3a0c8

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

include/net/tcp.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1637,7 +1637,6 @@ struct tcp_iter_state {
16371637
enum tcp_seq_states state;
16381638
struct sock *syn_wait_sk;
16391639
int bucket, offset, sbucket, num;
1640-
kuid_t uid;
16411640
loff_t last_pos;
16421641
};
16431642

net/ipv4/tcp_ipv4.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1871,7 +1871,6 @@ static void *listening_get_next(struct seq_file *seq, void *cur)
18711871
spin_lock_bh(&icsk->icsk_accept_queue.syn_wait_lock);
18721872
if (reqsk_queue_len(&icsk->icsk_accept_queue)) {
18731873
start_req:
1874-
st->uid = sock_i_uid(sk);
18751874
st->syn_wait_sk = sk;
18761875
st->state = TCP_SEQ_STATE_OPENREQ;
18771876
st->sbucket = 0;
@@ -2151,7 +2150,7 @@ void tcp_proc_unregister(struct net *net, struct tcp_seq_afinfo *afinfo)
21512150
EXPORT_SYMBOL(tcp_proc_unregister);
21522151

21532152
static void get_openreq4(const struct request_sock *req,
2154-
struct seq_file *f, int i, kuid_t uid)
2153+
struct seq_file *f, int i)
21552154
{
21562155
const struct inet_request_sock *ireq = inet_rsk(req);
21572156
long delta = req->rsk_timer.expires - jiffies;
@@ -2168,7 +2167,8 @@ static void get_openreq4(const struct request_sock *req,
21682167
1, /* timers active (only the expire timer) */
21692168
jiffies_delta_to_clock_t(delta),
21702169
req->num_timeout,
2171-
from_kuid_munged(seq_user_ns(f), uid),
2170+
from_kuid_munged(seq_user_ns(f),
2171+
sock_i_uid(req->rsk_listener)),
21722172
0, /* non standard timer */
21732173
0, /* open_requests have no inode */
21742174
0,
@@ -2278,7 +2278,7 @@ static int tcp4_seq_show(struct seq_file *seq, void *v)
22782278
get_tcp4_sock(v, seq, st->num);
22792279
break;
22802280
case TCP_SEQ_STATE_OPENREQ:
2281-
get_openreq4(v, seq, st->num, st->uid);
2281+
get_openreq4(v, seq, st->num);
22822282
break;
22832283
}
22842284
out:

net/ipv6/tcp_ipv6.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1635,7 +1635,7 @@ static void tcp_v6_destroy_sock(struct sock *sk)
16351635
#ifdef CONFIG_PROC_FS
16361636
/* Proc filesystem TCPv6 sock list dumping. */
16371637
static void get_openreq6(struct seq_file *seq,
1638-
struct request_sock *req, int i, kuid_t uid)
1638+
const struct request_sock *req, int i)
16391639
{
16401640
long ttd = req->rsk_timer.expires - jiffies;
16411641
const struct in6_addr *src = &inet_rsk(req)->ir_v6_loc_addr;
@@ -1659,7 +1659,8 @@ static void get_openreq6(struct seq_file *seq,
16591659
1, /* timers active (only the expire timer) */
16601660
jiffies_to_clock_t(ttd),
16611661
req->num_timeout,
1662-
from_kuid_munged(seq_user_ns(seq), uid),
1662+
from_kuid_munged(seq_user_ns(seq),
1663+
sock_i_uid(req->rsk_listener)),
16631664
0, /* non standard timer */
16641665
0, /* open_requests have no inode */
16651666
0, req);
@@ -1773,7 +1774,7 @@ static int tcp6_seq_show(struct seq_file *seq, void *v)
17731774
get_tcp6_sock(seq, v, st->num);
17741775
break;
17751776
case TCP_SEQ_STATE_OPENREQ:
1776-
get_openreq6(seq, v, st->num, st->uid);
1777+
get_openreq6(seq, v, st->num);
17771778
break;
17781779
}
17791780
out:

0 commit comments

Comments
 (0)