Skip to content

Commit a2225d9

Browse files
committed
autofs: remove left-over autofs4 stubs
There's no need to retain the fs/autofs4 directory for backward compatibility. Adding an AUTOFS4_FS fragment to the autofs Kconfig and a module alias for autofs4 is sufficient for almost all cases. Not keeping fs/autofs4 remnants will prevent "insmod <path>/autofs4/autofs4.ko" from working but this shouldn't be used in automation scripts rather than modprobe(8). There were some comments about things to look out for with the module rename in the fs/autofs4/Kconfig that is removed by this patch, see the commit patch if you are interested. One potential problem with this change is that when the fs/autofs/Kconfig fragment for AUTOFS4_FS is removed any AUTOFS4_FS entries will be removed from the kernel config, resulting in no autofs file system being built if there is no AUTOFS_FS entry also. This would have also happened if the fs/autofs4 remnants had remained and is most likely to be a problem with automated builds. Please check your build configurations before the removal which will occur after the next couple of kernel releases. Acked-by: Ian Kent <[email protected]> [ With edits and commit message from Ian Kent ] Signed-off-by: Linus Torvalds <[email protected]>
1 parent 0f105cf commit a2225d9

File tree

6 files changed

+12
-57
lines changed

6 files changed

+12
-57
lines changed

fs/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ source "fs/notify/Kconfig"
110110
source "fs/quota/Kconfig"
111111

112112
source "fs/autofs/Kconfig"
113-
source "fs/autofs4/Kconfig"
114113
source "fs/fuse/Kconfig"
115114
source "fs/overlayfs/Kconfig"
116115

fs/Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ obj-$(CONFIG_ROMFS_FS) += romfs/
103103
obj-$(CONFIG_QNX4FS_FS) += qnx4/
104104
obj-$(CONFIG_QNX6FS_FS) += qnx6/
105105
obj-$(CONFIG_AUTOFS_FS) += autofs/
106-
obj-$(CONFIG_AUTOFS4_FS) += autofs4/
107106
obj-$(CONFIG_ADFS_FS) += adfs/
108107
obj-$(CONFIG_FUSE_FS) += fuse/
109108
obj-$(CONFIG_OVERLAY_FS) += overlayfs/

fs/autofs/Kconfig

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
config AUTOFS4_FS
2+
tristate "Old Kconfig name for Kernel automounter support"
3+
select AUTOFS_FS
4+
help
5+
This name exists for people to just automatically pick up the
6+
new name of the autofs Kconfig option. All it does is select
7+
thenew new option name.
8+
9+
It will go away in a release or two as people have
10+
transitioned to just plain AUTOFS_FS.
11+
112
config AUTOFS_FS
213
tristate "Kernel automounter support (supports v3, v4 and v5)"
314
default n

fs/autofs/init.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ static struct file_system_type autofs_fs_type = {
2323
.kill_sb = autofs_kill_sb,
2424
};
2525
MODULE_ALIAS_FS("autofs");
26+
MODULE_ALIAS("autofs4");
2627

2728
static int __init init_autofs_fs(void)
2829
{

fs/autofs4/Kconfig

Lines changed: 0 additions & 46 deletions
This file was deleted.

fs/autofs4/Makefile

Lines changed: 0 additions & 9 deletions
This file was deleted.

0 commit comments

Comments
 (0)