Skip to content

Commit a09bae0

Browse files
yu-chen-surfIngo Molnar
authored andcommitted
x86/boot/e820: Rename the e820_table_firmware to e820_table_kexec
Currently the e820_table_firmware[] table is mainly used by the kexec, and it is not what it's supposed to be - despite its name it might be modified by the kernel. So change its name to e820_table_kexec[]. In the next patch we will introduce the real e820_table_firmware[] table. No functional change. Signed-off-by: Chen Yu <[email protected]> Cc: Linus Torvalds <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Xunlei Pang <[email protected]> Cc: [email protected] Signed-off-by: Ingo Molnar <[email protected]>
1 parent b7a67e0 commit a09bae0

File tree

4 files changed

+26
-26
lines changed

4 files changed

+26
-26
lines changed

arch/x86/include/asm/e820/api.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#include <asm/e820/types.h>
55

66
extern struct e820_table *e820_table;
7-
extern struct e820_table *e820_table_firmware;
7+
extern struct e820_table *e820_table_kexec;
88

99
extern unsigned long pci_mem_start;
1010

arch/x86/kernel/e820.c

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
/*
2323
* We organize the E820 table into two main data structures:
2424
*
25-
* - 'e820_table_firmware': the original firmware version passed to us by the
25+
* - 'e820_table_kexec': the original firmware version passed to us by the
2626
* bootloader - not modified by the kernel. We use this to:
2727
*
2828
* - inform the user about the firmware's notion of memory layout
@@ -46,10 +46,10 @@
4646
* specific memory layout data during early bootup.
4747
*/
4848
static struct e820_table e820_table_init __initdata;
49-
static struct e820_table e820_table_firmware_init __initdata;
49+
static struct e820_table e820_table_kexec_init __initdata;
5050

5151
struct e820_table *e820_table __refdata = &e820_table_init;
52-
struct e820_table *e820_table_firmware __refdata = &e820_table_firmware_init;
52+
struct e820_table *e820_table_kexec __refdata = &e820_table_kexec_init;
5353

5454
/* For PCI or other memory-mapped resources */
5555
unsigned long pci_mem_start = 0xaeedbabe;
@@ -470,9 +470,9 @@ u64 __init e820__range_update(u64 start, u64 size, enum e820_type old_type, enum
470470
return __e820__range_update(e820_table, start, size, old_type, new_type);
471471
}
472472

473-
static u64 __init e820__range_update_firmware(u64 start, u64 size, enum e820_type old_type, enum e820_type new_type)
473+
static u64 __init e820__range_update_kexec(u64 start, u64 size, enum e820_type old_type, enum e820_type new_type)
474474
{
475-
return __e820__range_update(e820_table_firmware, start, size, old_type, new_type);
475+
return __e820__range_update(e820_table_kexec, start, size, old_type, new_type);
476476
}
477477

478478
/* Remove a range of memory from the E820 table: */
@@ -546,9 +546,9 @@ void __init e820__update_table_print(void)
546546
e820__print_table("modified");
547547
}
548548

549-
static void __init e820__update_table_firmware(void)
549+
static void __init e820__update_table_kexec(void)
550550
{
551-
e820__update_table(e820_table_firmware);
551+
e820__update_table(e820_table_kexec);
552552
}
553553

554554
#define MAX_GAP_END 0x100000000ull
@@ -623,7 +623,7 @@ __init void e820__setup_pci_gap(void)
623623
/*
624624
* Called late during init, in free_initmem().
625625
*
626-
* Initial e820_table and e820_table_firmware are largish __initdata arrays.
626+
* Initial e820_table and e820_table_kexec are largish __initdata arrays.
627627
*
628628
* Copy them to a (usually much smaller) dynamically allocated area that is
629629
* sized precisely after the number of e820 entries.
@@ -643,11 +643,11 @@ __init void e820__reallocate_tables(void)
643643
memcpy(n, e820_table, size);
644644
e820_table = n;
645645

646-
size = offsetof(struct e820_table, entries) + sizeof(struct e820_entry)*e820_table_firmware->nr_entries;
646+
size = offsetof(struct e820_table, entries) + sizeof(struct e820_entry)*e820_table_kexec->nr_entries;
647647
n = kmalloc(size, GFP_KERNEL);
648648
BUG_ON(!n);
649-
memcpy(n, e820_table_firmware, size);
650-
e820_table_firmware = n;
649+
memcpy(n, e820_table_kexec, size);
650+
e820_table_kexec = n;
651651
}
652652

653653
/*
@@ -669,7 +669,7 @@ void __init e820__memory_setup_extended(u64 phys_addr, u32 data_len)
669669
__append_e820_table(extmap, entries);
670670
e820__update_table(e820_table);
671671

672-
memcpy(e820_table_firmware, e820_table, sizeof(*e820_table_firmware));
672+
memcpy(e820_table_kexec, e820_table, sizeof(*e820_table_kexec));
673673

674674
early_memunmap(sdata, data_len);
675675
pr_info("e820: extended physical RAM map:\n");
@@ -729,7 +729,7 @@ core_initcall(e820__register_nvs_regions);
729729
/*
730730
* Allocate the requested number of bytes with the requsted alignment
731731
* and return (the physical address) to the caller. Also register this
732-
* range in the 'firmware' E820 table as a reserved range.
732+
* range in the 'kexec' E820 table as a reserved range.
733733
*
734734
* This allows kexec to fake a new mptable, as if it came from the real
735735
* system.
@@ -740,9 +740,9 @@ u64 __init e820__memblock_alloc_reserved(u64 size, u64 align)
740740

741741
addr = __memblock_alloc_base(size, align, MEMBLOCK_ALLOC_ACCESSIBLE);
742742
if (addr) {
743-
e820__range_update_firmware(addr, size, E820_TYPE_RAM, E820_TYPE_RESERVED);
744-
pr_info("e820: update e820_table_firmware for e820__memblock_alloc_reserved()\n");
745-
e820__update_table_firmware();
743+
e820__range_update_kexec(addr, size, E820_TYPE_RAM, E820_TYPE_RESERVED);
744+
pr_info("e820: update e820_table_kexec for e820__memblock_alloc_reserved()\n");
745+
e820__update_table_kexec();
746746
}
747747

748748
return addr;
@@ -925,13 +925,13 @@ void __init e820__reserve_setup_data(void)
925925
while (pa_data) {
926926
data = early_memremap(pa_data, sizeof(*data));
927927
e820__range_update(pa_data, sizeof(*data)+data->len, E820_TYPE_RAM, E820_TYPE_RESERVED_KERN);
928-
e820__range_update_firmware(pa_data, sizeof(*data)+data->len, E820_TYPE_RAM, E820_TYPE_RESERVED_KERN);
928+
e820__range_update_kexec(pa_data, sizeof(*data)+data->len, E820_TYPE_RAM, E820_TYPE_RESERVED_KERN);
929929
pa_data = data->next;
930930
early_memunmap(data, sizeof(*data));
931931
}
932932

933933
e820__update_table(e820_table);
934-
e820__update_table(e820_table_firmware);
934+
e820__update_table(e820_table_kexec);
935935

936936
pr_info("extended physical RAM map:\n");
937937
e820__print_table("reserve setup_data");
@@ -1064,8 +1064,8 @@ void __init e820__reserve_resources(void)
10641064
res++;
10651065
}
10661066

1067-
for (i = 0; i < e820_table_firmware->nr_entries; i++) {
1068-
struct e820_entry *entry = e820_table_firmware->entries + i;
1067+
for (i = 0; i < e820_table_kexec->nr_entries; i++) {
1068+
struct e820_entry *entry = e820_table_kexec->entries + i;
10691069

10701070
firmware_map_add_early(entry->addr, entry->addr + entry->size, e820_type_to_string(entry));
10711071
}
@@ -1177,7 +1177,7 @@ void __init e820__memory_setup(void)
11771177

11781178
who = x86_init.resources.memory_setup();
11791179

1180-
memcpy(e820_table_firmware, e820_table, sizeof(*e820_table_firmware));
1180+
memcpy(e820_table_kexec, e820_table, sizeof(*e820_table_kexec));
11811181

11821182
pr_info("e820: BIOS-provided physical RAM map:\n");
11831183
e820__print_table(who);

arch/x86/kernel/kexec-bzimage64.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,14 +100,14 @@ static int setup_e820_entries(struct boot_params *params)
100100
{
101101
unsigned int nr_e820_entries;
102102

103-
nr_e820_entries = e820_table_firmware->nr_entries;
103+
nr_e820_entries = e820_table_kexec->nr_entries;
104104

105105
/* TODO: Pass entries more than E820_MAX_ENTRIES_ZEROPAGE in bootparams setup data */
106106
if (nr_e820_entries > E820_MAX_ENTRIES_ZEROPAGE)
107107
nr_e820_entries = E820_MAX_ENTRIES_ZEROPAGE;
108108

109109
params->e820_entries = nr_e820_entries;
110-
memcpy(&params->e820_table, &e820_table_firmware->entries, nr_e820_entries*sizeof(struct e820_entry));
110+
memcpy(&params->e820_table, &e820_table_kexec->entries, nr_e820_entries*sizeof(struct e820_entry));
111111

112112
return 0;
113113
}

arch/x86/power/hibernate_64.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ static int get_e820_md5(struct e820_table *table, void *buf)
251251

252252
static void hibernation_e820_save(void *buf)
253253
{
254-
get_e820_md5(e820_table_firmware, buf);
254+
get_e820_md5(e820_table_kexec, buf);
255255
}
256256

257257
static bool hibernation_e820_mismatch(void *buf)
@@ -264,7 +264,7 @@ static bool hibernation_e820_mismatch(void *buf)
264264
if (!memcmp(result, buf, MD5_DIGEST_SIZE))
265265
return false;
266266

267-
ret = get_e820_md5(e820_table_firmware, result);
267+
ret = get_e820_md5(e820_table_kexec, result);
268268
if (ret)
269269
return true;
270270

0 commit comments

Comments
 (0)