Skip to content

Commit a078120

Browse files
committed
apparmor: cleanup: simplify code to get ns symlink name
ns_get_name() is called in only one place and can be folded in. Signed-off-by: John Johansen <[email protected]>
1 parent cf91600 commit a078120

File tree

1 file changed

+6
-19
lines changed

1 file changed

+6
-19
lines changed

security/apparmor/apparmorfs.c

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,7 @@ static int aafs_count;
119119

120120
static int aafs_show_path(struct seq_file *seq, struct dentry *dentry)
121121
{
122-
struct inode *inode = d_inode(dentry);
123-
124-
seq_printf(seq, "%s:[%lu]", AAFS_NAME, inode->i_ino);
122+
seq_printf(seq, "%s:[%lu]", AAFS_NAME, d_inode(dentry)->i_ino);
125123
return 0;
126124
}
127125

@@ -2392,29 +2390,18 @@ static const char *policy_get_link(struct dentry *dentry,
23922390
return NULL;
23932391
}
23942392

2395-
static int ns_get_name(char *buf, size_t size, struct aa_ns *ns,
2396-
struct inode *inode)
2397-
{
2398-
int res = snprintf(buf, size, "%s:[%lu]", AAFS_NAME, inode->i_ino);
2399-
2400-
if (res < 0 || res >= size)
2401-
res = -ENOENT;
2402-
2403-
return res;
2404-
}
2405-
24062393
static int policy_readlink(struct dentry *dentry, char __user *buffer,
24072394
int buflen)
24082395
{
2409-
struct aa_ns *ns;
24102396
char name[32];
24112397
int res;
24122398

2413-
ns = aa_get_current_ns();
2414-
res = ns_get_name(name, sizeof(name), ns, d_inode(dentry));
2415-
if (res >= 0)
2399+
res = snprintf(name, sizeof(name), "%s:[%lu]", AAFS_NAME,
2400+
d_inode(dentry)->i_ino);
2401+
if (res > 0 && res < sizeof(name))
24162402
res = readlink_copy(buffer, buflen, name);
2417-
aa_put_ns(ns);
2403+
else
2404+
res = -ENOENT;
24182405

24192406
return res;
24202407
}

0 commit comments

Comments
 (0)