mm, slub: discard slabs in unfreeze_partials() without irqs disabled

tehcaster · tehcaster · commit 8de06a6f48f2 · 2021-09-04T01:12:22.000+02:00
No need for disabled irqs when discarding slabs, so restore them before
discarding.

Signed-off-by: Vlastimil Babka &lt;vbabka@suse.cz&gt;
diff --git a/mm/slub.c b/mm/slub.c
@@ -2406,6 +2406,8 @@ static void unfreeze_partials(struct kmem_cache *s,
 	if (n)
 		spin_unlock(&n->list_lock);
 
+	local_irq_restore(flags);
+
 	while (discard_page) {
 		page = discard_page;
 		discard_page = discard_page->next;
@@ -2415,7 +2417,6 @@ static void unfreeze_partials(struct kmem_cache *s,
 		stat(s, FREE_SLAB);
 	}
 
-	local_irq_restore(flags);
 #endif	/* CONFIG_SLUB_CPU_PARTIAL */
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2406,6 +2406,8 @@ static void unfreeze_partials(struct kmem_cache *s,`
`2406`	`2406`	`if (n)`
`2407`	`2407`	`spin_unlock(&n->list_lock);`
`2408`	`2408`
	`2409`	`+ local_irq_restore(flags);`
	`2410`	`+`
`2409`	`2411`	`while (discard_page) {`
`2410`	`2412`	`page = discard_page;`
`2411`	`2413`	`discard_page = discard_page->next;`
`@@ -2415,7 +2417,6 @@ static void unfreeze_partials(struct kmem_cache *s,`
`2415`	`2417`	`stat(s, FREE_SLAB);`
`2416`	`2418`	`}`
`2417`	`2419`
`2418`		`- local_irq_restore(flags);`
`2419`	`2420`	`#endif /* CONFIG_SLUB_CPU_PARTIAL */`
`2420`	`2421`	`}`
`2421`	`2422`