Skip to content

Commit 8b97477

Browse files
matttbedavem330
authored andcommitted
selftests: mptcp: interpret \n as a new line
In case of errors, this message was printed: (...) # read: Resource temporarily unavailable # client exit code 0, server 3 # \nnetns ns1-0-BJlt5D socket stat for 10003: (...) Obviously, the idea was to add a new line before the socket stat and not print "\nnetns". Fixes: b08fbf2 ("selftests: add test-cases for MPTCP MP_JOIN") Fixes: 048d19d ("mptcp: add basic kselftest for mptcp") Signed-off-by: Matthieu Baerts <[email protected]> Acked-by: Paolo Abeni <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent b79a80b commit 8b97477

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

tools/testing/selftests/net/mptcp/mptcp_connect.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -443,9 +443,9 @@ do_transfer()
443443
duration=$(printf "(duration %05sms)" $duration)
444444
if [ ${rets} -ne 0 ] || [ ${retc} -ne 0 ]; then
445445
echo "$duration [ FAIL ] client exit code $retc, server $rets" 1>&2
446-
echo "\nnetns ${listener_ns} socket stat for $port:" 1>&2
446+
echo -e "\nnetns ${listener_ns} socket stat for ${port}:" 1>&2
447447
ip netns exec ${listener_ns} ss -nita 1>&2 -o "sport = :$port"
448-
echo "\nnetns ${connector_ns} socket stat for $port:" 1>&2
448+
echo -e "\nnetns ${connector_ns} socket stat for ${port}:" 1>&2
449449
ip netns exec ${connector_ns} ss -nita 1>&2 -o "dport = :$port"
450450
451451
cat "$capout"

tools/testing/selftests/net/mptcp/mptcp_join.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,9 @@ do_transfer()
176176

177177
if [ ${rets} -ne 0 ] || [ ${retc} -ne 0 ]; then
178178
echo " client exit code $retc, server $rets" 1>&2
179-
echo "\nnetns ${listener_ns} socket stat for $port:" 1>&2
179+
echo -e "\nnetns ${listener_ns} socket stat for ${port}:" 1>&2
180180
ip netns exec ${listener_ns} ss -nita 1>&2 -o "sport = :$port"
181-
echo "\nnetns ${connector_ns} socket stat for $port:" 1>&2
181+
echo -e "\nnetns ${connector_ns} socket stat for ${port}:" 1>&2
182182
ip netns exec ${connector_ns} ss -nita 1>&2 -o "dport = :$port"
183183

184184
cat "$capout"

0 commit comments

Comments
 (0)