Skip to content

Commit 8b55e55

Browse files
krzkrafaeljw
authored andcommitted
PM / Domains: Handle safely genpd_syscore_switch() call on non-genpd device
genpd_syscore_switch() had two problems: 1. It silently assumed that device, it is being called for, belongs to generic power domain and used container_of() on its power domain pointer. Such assumption might not be true always. 2. It iterated over list of generic power domains without holding gpd_list_lock mutex thus list could have been modified at the same time. Usage of genpd_lookup_dev() solves both problems as it is safe a call for non-generic power domains and uses mutex when iterating. Reported-by: Ulf Hansson <[email protected]> Signed-off-by: Krzysztof Kozlowski <[email protected]> Acked-by: Ulf Hansson <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 10da654 commit 8b55e55

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/base/power/domain.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1148,8 +1148,8 @@ static void genpd_syscore_switch(struct device *dev, bool suspend)
11481148
{
11491149
struct generic_pm_domain *genpd;
11501150

1151-
genpd = dev_to_genpd(dev);
1152-
if (!pm_genpd_present(genpd))
1151+
genpd = genpd_lookup_dev(dev);
1152+
if (!genpd)
11531153
return;
11541154

11551155
if (suspend) {

0 commit comments

Comments
 (0)