Skip to content

Commit 8116acc

Browse files
weiyjbjorn-helgaas
authored andcommitted
PCI: keystone: Propagate request_irq() failure
Previously, if request_irq() failed, ks_add_pcie_port() always returned zero (success). Return the request_irq() failure result instead. [bhelgaas: changelog] Signed-off-by: Wei Yongjun <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Acked-By: Murali Karicheri <[email protected]>
1 parent 29b4817 commit 8116acc

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/pci/host/pci-keystone.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -334,8 +334,9 @@ static int __init ks_add_pcie_port(struct keystone_pcie *ks_pcie,
334334
if (ks_pcie->error_irq <= 0)
335335
dev_info(&pdev->dev, "no error IRQ defined\n");
336336
else {
337-
if (request_irq(ks_pcie->error_irq, pcie_err_irq_handler,
338-
IRQF_SHARED, "pcie-error-irq", ks_pcie) < 0) {
337+
ret = request_irq(ks_pcie->error_irq, pcie_err_irq_handler,
338+
IRQF_SHARED, "pcie-error-irq", ks_pcie);
339+
if (ret < 0) {
339340
dev_err(&pdev->dev, "failed to request error IRQ %d\n",
340341
ks_pcie->error_irq);
341342
return ret;

0 commit comments

Comments
 (0)