Skip to content

Commit 6c8b120

Browse files
committed
PCI: altera: Remove redundant platform_get_resource() return value check
devm_ioremap_resource() fails gracefully when given a NULL resource pointer, so we don't need to check separately for failure from platform_get_resource_byname(). Remove the redundant check. Signed-off-by: Bjorn Helgaas <[email protected]>
1 parent ce4f1c7 commit 6c8b120

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

drivers/pci/host/pcie-altera-msi.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -237,11 +237,6 @@ static int altera_msi_probe(struct platform_device *pdev)
237237
msi->pdev = pdev;
238238

239239
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "csr");
240-
if (!res) {
241-
dev_err(&pdev->dev, "no csr memory resource defined\n");
242-
return -ENODEV;
243-
}
244-
245240
msi->csr_base = devm_ioremap_resource(&pdev->dev, res);
246241
if (IS_ERR(msi->csr_base)) {
247242
dev_err(&pdev->dev, "failed to map csr memory\n");
@@ -250,11 +245,6 @@ static int altera_msi_probe(struct platform_device *pdev)
250245

251246
res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
252247
"vector_slave");
253-
if (!res) {
254-
dev_err(&pdev->dev, "no vector_slave memory resource defined\n");
255-
return -ENODEV;
256-
}
257-
258248
msi->vector_base = devm_ioremap_resource(&pdev->dev, res);
259249
if (IS_ERR(msi->vector_base)) {
260250
dev_err(&pdev->dev, "failed to map vector_slave memory\n");

0 commit comments

Comments
 (0)