Skip to content

Commit 66922f8

Browse files
kleinermemersion
authored andcommitted
drm: Fix HDMI_STATIC_METADATA_TYPE1 constant
According to the CTA 861.G spec, HDMI_STATIC_METADATA_TYPE1 is not 1, but zero, so fix this enum. While this doesn't cause problems in the kernel yet, as the constant isn't actively used by drivers yet, it did create confusion while debugging HDR problems in yours truly, and also potential bugs in userspace components, as the wrong enum propagates to components, e.g., like it did already into intel-gpu-tools (tests/kms_hdr.c) or is used as wrong reference when writing future new userspace HDR components like compositors. Fixes: fbb5d03 ("drm: Add HDR source metadata property") Signed-off-by: Mario Kleiner <[email protected]> Cc: Uma Shankar <[email protected]> Cc: Shashank Sharma <[email protected]> Cc: Ville Syrjälä <[email protected]> Reviewed-by: Simon Ser <[email protected]> Signed-off-by: Simon Ser <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent d71cbff commit 66922f8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/linux/hdmi.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ enum hdmi_content_type {
156156
};
157157

158158
enum hdmi_metadata_type {
159-
HDMI_STATIC_METADATA_TYPE1 = 1,
159+
HDMI_STATIC_METADATA_TYPE1 = 0,
160160
};
161161

162162
enum hdmi_eotf {

0 commit comments

Comments
 (0)