Skip to content

Commit 659c9bc

Browse files
bwhacksstorulf
authored andcommitted
mmc: sdhci-pci: Build o2micro support in the same module
sdhci-pci-o2micro.c contains no initialisation and its functions are only called from shdci-pci.c, so there is no reason for it to be a separate module, let alone or for it to always be built-in. - Rename sdhci-pci.c to sdhci-pci-core.c so that the sdhci-pci module can be built from multiple source files - Add sdhci-pci-o2micro.c to it - Remove redundant exports Signed-off-by: Ben Hutchings <[email protected]> Signed-off-by: Ulf Hansson <[email protected]>
1 parent 0de9125 commit 659c9bc

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed

drivers/mmc/host/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ obj-$(CONFIG_MMC_MXC) += mxcmmc.o
99
obj-$(CONFIG_MMC_MXS) += mxs-mmc.o
1010
obj-$(CONFIG_MMC_SDHCI) += sdhci.o
1111
obj-$(CONFIG_MMC_SDHCI_PCI) += sdhci-pci.o
12+
sdhci-pci-y += sdhci-pci-core.o sdhci-pci-o2micro.o
1213
obj-$(subst m,y,$(CONFIG_MMC_SDHCI_PCI)) += sdhci-pci-data.o
13-
obj-$(subst m,y,$(CONFIG_MMC_SDHCI_PCI)) += sdhci-pci-o2micro.o
1414
obj-$(CONFIG_MMC_SDHCI_ACPI) += sdhci-acpi.o
1515
obj-$(CONFIG_MMC_SDHCI_PXAV3) += sdhci-pxav3.o
1616
obj-$(CONFIG_MMC_SDHCI_PXAV2) += sdhci-pxav2.o
File renamed without changes.

drivers/mmc/host/sdhci-pci-o2micro.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ void sdhci_pci_o2_fujin2_pci_init(struct sdhci_pci_chip *chip)
145145
scratch_32 |= 0x00080000;
146146
pci_write_config_dword(chip->pdev, O2_SD_MISC_CTRL4, scratch_32);
147147
}
148-
EXPORT_SYMBOL_GPL(sdhci_pci_o2_fujin2_pci_init);
149148

150149
int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
151150
{
@@ -179,7 +178,6 @@ int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
179178

180179
return 0;
181180
}
182-
EXPORT_SYMBOL_GPL(sdhci_pci_o2_probe_slot);
183181

184182
int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
185183
{
@@ -385,11 +383,9 @@ int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip)
385383

386384
return 0;
387385
}
388-
EXPORT_SYMBOL_GPL(sdhci_pci_o2_probe);
389386

390387
int sdhci_pci_o2_resume(struct sdhci_pci_chip *chip)
391388
{
392389
sdhci_pci_o2_probe(chip);
393390
return 0;
394391
}
395-
EXPORT_SYMBOL_GPL(sdhci_pci_o2_resume);

0 commit comments

Comments
 (0)