Skip to content

Commit 52dfa12

Browse files
Villemoesdanvet
authored andcommitted
drm/gma500: fix error path in gma_intel_setup_gmbus()
The current code fails to call i2c_del_adapter on dev_prev->gmbus[0].adapter, and if the for loop above failed already at i==0, all hell breaks loose when we do the loop body for i = -1,-2,... Signed-off-by: Rasmus Villemoes <[email protected]> Link: http://patchwork.freedesktop.org/patch/msgid/[email protected] Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Daniel Vetter <[email protected]>
1 parent 4c61716 commit 52dfa12

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/gma500/intel_gmbus.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ int gma_intel_setup_gmbus(struct drm_device *dev)
436436
return 0;
437437

438438
err:
439-
while (--i) {
439+
while (i--) {
440440
struct intel_gmbus *bus = &dev_priv->gmbus[i];
441441
i2c_del_adapter(&bus->adapter);
442442
}

0 commit comments

Comments
 (0)