Skip to content

Commit 4e594ad

Browse files
Alexandru EliseiMarc Zyngier
authored andcommitted
irqchip/gic-v3: Spell out when pseudo-NMIs are enabled
When NMIs cannot be enabled, the driver prints a message stating that unambiguously. When they are enabled, the only feedback we get is a message regarding the use of synchronization for ICC_PMR_EL1 writes, which is not as useful for a user who is not intimately familiar with how NMIs are implemented. Let's make it obvious that pseudo-NMIs are enabled. Keep the message about using a barrier for ICC_PMR_EL1 writes, because it has a non-negligible impact on performance. Signed-off-by: Alexandru Elisei <[email protected]> Signed-off-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent f4d51df commit 4e594ad

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/irqchip/irq-gic-v3.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1564,8 +1564,8 @@ static void gic_enable_nmi_support(void)
15641564
if (gic_read_ctlr() & ICC_CTLR_EL1_PMHE_MASK)
15651565
static_branch_enable(&gic_pmr_sync);
15661566

1567-
pr_info("%s ICC_PMR_EL1 synchronisation\n",
1568-
static_branch_unlikely(&gic_pmr_sync) ? "Forcing" : "Relaxing");
1567+
pr_info("Pseudo-NMIs enabled using %s ICC_PMR_EL1 synchronisation\n",
1568+
static_branch_unlikely(&gic_pmr_sync) ? "forced" : "relaxed");
15691569

15701570
static_branch_enable(&supports_pseudo_nmis);
15711571

0 commit comments

Comments
 (0)