Skip to content

Commit 4a4d371

Browse files
Jiri Olsaacmel
authored andcommitted
perf record: Remove -f/--force option
It no longer have any affect on the processing and is marked as obsolete anyway. Signed-off-by: Jiri Olsa <[email protected]> Cc: Andi Kleen <[email protected]> Cc: Corey Ashford <[email protected]> Cc: David Ahern <[email protected]> Cc: Frederic Weisbecker <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Paul Mackerras <[email protected]> Cc: Peter Zijlstra <[email protected]> Link: http://lkml.kernel.org/n/[email protected] Link: http://lkml.kernel.org/r/[email protected] [ combined patch removing the -f usage in various sub-commands, such as 'perf sched', etc, by Namhyung Kim ] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent 563aecb commit 4a4d371

File tree

7 files changed

+6
-14
lines changed

7 files changed

+6
-14
lines changed

tools/perf/Documentation/examples.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ Furthermore, these tracepoints can be used to sample the workload as
6666
well. For example the page allocations done by a 'git gc' can be
6767
captured the following way:
6868

69-
titan:~/git> perf record -f -e kmem:mm_page_alloc -c 1 ./git gc
69+
titan:~/git> perf record -e kmem:mm_page_alloc -c 1 ./git gc
7070
Counting objects: 1148, done.
7171
Delta compression using up to 2 threads.
7272
Compressing objects: 100% (450/450), done.
@@ -120,7 +120,7 @@ Furthermore, call-graph sampling can be done too, of page
120120
allocations - to see precisely what kind of page allocations there
121121
are:
122122

123-
titan:~/git> perf record -f -g -e kmem:mm_page_alloc -c 1 ./git gc
123+
titan:~/git> perf record -g -e kmem:mm_page_alloc -c 1 ./git gc
124124
Counting objects: 1148, done.
125125
Delta compression using up to 2 threads.
126126
Compressing objects: 100% (450/450), done.

tools/perf/Documentation/perf-record.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,6 @@ OPTIONS
7070
--no-delay::
7171
Collect data without buffering.
7272

73-
-f::
74-
--force::
75-
Overwrite existing data file. (deprecated)
76-
7773
-c::
7874
--count=::
7975
Event period to sample.

tools/perf/builtin-kmem.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -708,7 +708,7 @@ static int parse_line_opt(const struct option *opt __maybe_unused,
708708
static int __cmd_record(int argc, const char **argv)
709709
{
710710
const char * const record_args[] = {
711-
"record", "-a", "-R", "-f", "-c", "1",
711+
"record", "-a", "-R", "-c", "1",
712712
"-e", "kmem:kmalloc",
713713
"-e", "kmem:kmalloc_node",
714714
"-e", "kmem:kfree",

tools/perf/builtin-lock.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -878,7 +878,7 @@ static int __cmd_report(void)
878878
static int __cmd_record(int argc, const char **argv)
879879
{
880880
const char *record_args[] = {
881-
"record", "-R", "-f", "-m", "1024", "-c", "1",
881+
"record", "-R", "-m", "1024", "-c", "1",
882882
};
883883
unsigned int rec_argc, i, j;
884884
const char **rec_argv;

tools/perf/builtin-record.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ struct perf_record {
7474
int realtime_prio;
7575
bool no_buildid;
7676
bool no_buildid_cache;
77-
bool force;
7877
long samples;
7978
off_t post_processing_offset;
8079
};
@@ -856,8 +855,6 @@ const struct option record_options[] = {
856855
"system-wide collection from all CPUs"),
857856
OPT_STRING('C', "cpu", &record.opts.target.cpu_list, "cpu",
858857
"list of cpus to monitor"),
859-
OPT_BOOLEAN('f', "force", &record.force,
860-
"overwrite existing data file (deprecated)"),
861858
OPT_U64('c', "count", &record.opts.user_interval, "event period to sample"),
862859
OPT_STRING('o', "output", &record.output_name, "file",
863860
"output file name"),

tools/perf/builtin-sched.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1632,7 +1632,6 @@ static int __cmd_record(int argc, const char **argv)
16321632
"record",
16331633
"-a",
16341634
"-R",
1635-
"-f",
16361635
"-m", "1024",
16371636
"-c", "1",
16381637
"-e", "sched:sched_switch",

tools/perf/builtin-timechart.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1005,7 +1005,7 @@ static int __cmd_record(int argc, const char **argv)
10051005
{
10061006
#ifdef SUPPORT_OLD_POWER_EVENTS
10071007
const char * const record_old_args[] = {
1008-
"record", "-a", "-R", "-f", "-c", "1",
1008+
"record", "-a", "-R", "-c", "1",
10091009
"-e", "power:power_start",
10101010
"-e", "power:power_end",
10111011
"-e", "power:power_frequency",
@@ -1014,7 +1014,7 @@ static int __cmd_record(int argc, const char **argv)
10141014
};
10151015
#endif
10161016
const char * const record_new_args[] = {
1017-
"record", "-a", "-R", "-f", "-c", "1",
1017+
"record", "-a", "-R", "-c", "1",
10181018
"-e", "power:cpu_frequency",
10191019
"-e", "power:cpu_idle",
10201020
"-e", "sched:sched_wakeup",

0 commit comments

Comments
 (0)