Skip to content

Commit 471aa70

Browse files
Christoph Hellwigaxboe
authored andcommitted
block: pass a gendisk to blk_queue_update_readahead
.. and rename the function to disk_update_readahead. This is in preparation for moving the BDI from the request_queue to the gendisk. Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: Jan Kara <[email protected]> Reviewed-by: Johannes Thumshirn <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent 5ed964f commit 471aa70

File tree

6 files changed

+10
-8
lines changed

6 files changed

+10
-8
lines changed

block/blk-settings.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -380,8 +380,10 @@ void blk_queue_alignment_offset(struct request_queue *q, unsigned int offset)
380380
}
381381
EXPORT_SYMBOL(blk_queue_alignment_offset);
382382

383-
void blk_queue_update_readahead(struct request_queue *q)
383+
void disk_update_readahead(struct gendisk *disk)
384384
{
385+
struct request_queue *q = disk->queue;
386+
385387
/*
386388
* For read-ahead of large files to be effective, we need to read ahead
387389
* at least twice the optimal I/O size.
@@ -391,7 +393,7 @@ void blk_queue_update_readahead(struct request_queue *q)
391393
q->backing_dev_info->io_pages =
392394
queue_max_sectors(q) >> (PAGE_SHIFT - 9);
393395
}
394-
EXPORT_SYMBOL_GPL(blk_queue_update_readahead);
396+
EXPORT_SYMBOL_GPL(disk_update_readahead);
395397

396398
/**
397399
* blk_limits_io_min - set minimum request size for a device
@@ -665,7 +667,7 @@ void disk_stack_limits(struct gendisk *disk, struct block_device *bdev,
665667
pr_notice("%s: Warning: Device %pg is misaligned\n",
666668
disk->disk_name, bdev);
667669

668-
blk_queue_update_readahead(disk->queue);
670+
disk_update_readahead(disk);
669671
}
670672
EXPORT_SYMBOL(disk_stack_limits);
671673

block/blk-sysfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -866,7 +866,7 @@ int blk_register_queue(struct gendisk *disk)
866866
"%s is registering an already registered queue\n",
867867
kobject_name(&dev->kobj));
868868

869-
blk_queue_update_readahead(q);
869+
disk_update_readahead(disk);
870870

871871
ret = blk_trace_init_sysfs(dev);
872872
if (ret)

drivers/block/drbd/drbd_nl.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1364,7 +1364,7 @@ static void drbd_setup_queue_param(struct drbd_device *device, struct drbd_backi
13641364

13651365
if (b) {
13661366
blk_stack_limits(&q->limits, &b->limits, 0);
1367-
blk_queue_update_readahead(q);
1367+
disk_update_readahead(device->vdisk);
13681368
}
13691369
fixup_discard_if_not_supported(q);
13701370
fixup_write_zeroes(device, q);

drivers/md/dm-table.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2076,7 +2076,7 @@ int dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
20762076
}
20772077

20782078
dm_update_keyslot_manager(q, t);
2079-
blk_queue_update_readahead(q);
2079+
disk_update_readahead(t->md->disk);
20802080

20812081
return 0;
20822082
}

drivers/nvme/host/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1890,7 +1890,7 @@ static int nvme_update_ns_info(struct nvme_ns *ns, struct nvme_id_ns *id)
18901890
nvme_update_disk_info(ns->head->disk, ns, id);
18911891
blk_stack_limits(&ns->head->disk->queue->limits,
18921892
&ns->queue->limits, 0);
1893-
blk_queue_update_readahead(ns->head->disk->queue);
1893+
disk_update_readahead(ns->head->disk);
18941894
blk_mq_unfreeze_queue(ns->head->disk->queue);
18951895
}
18961896
return 0;

include/linux/blkdev.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1139,7 +1139,7 @@ void blk_queue_zone_write_granularity(struct request_queue *q,
11391139
unsigned int size);
11401140
extern void blk_queue_alignment_offset(struct request_queue *q,
11411141
unsigned int alignment);
1142-
void blk_queue_update_readahead(struct request_queue *q);
1142+
void disk_update_readahead(struct gendisk *disk);
11431143
extern void blk_limits_io_min(struct queue_limits *limits, unsigned int min);
11441144
extern void blk_queue_io_min(struct request_queue *q, unsigned int min);
11451145
extern void blk_limits_io_opt(struct queue_limits *limits, unsigned int opt);

0 commit comments

Comments
 (0)