fork: Skip setting TIF_SIGPENDING in ptrace_init_task

ebiederm · ebiederm · commit 4390e9eadbbb · 2018-08-03T20:10:54.000-05:00
The code in calculate_sigpending will now handle this so
it is just redundant and possibly a little confusing
to continue setting TIF_SIGPENDING in ptrace_init_task.

Suggested-by: Oleg Nesterov &lt;oleg@redhat.com&gt;
Signed-off-by: "Eric W. Biederman" &lt;ebiederm@xmission.com&gt;
diff --git a/include/linux/ptrace.h b/include/linux/ptrace.h
@@ -214,8 +214,6 @@ static inline void ptrace_init_task(struct task_struct *child, bool ptrace)
 			task_set_jobctl_pending(child, JOBCTL_TRAP_STOP);
 		else
 			sigaddset(&child->pending.signal, SIGSTOP);
-
-		set_tsk_thread_flag(child, TIF_SIGPENDING);
 	}
 	else
 		child->ptracer_cred = NULL;

Original file line number	Diff line number	Diff line change
`@@ -214,8 +214,6 @@ static inline void ptrace_init_task(struct task_struct *child, bool ptrace)`
`214`	`214`	`task_set_jobctl_pending(child, JOBCTL_TRAP_STOP);`
`215`	`215`	`else`
`216`	`216`	`sigaddset(&child->pending.signal, SIGSTOP);`
`217`		`-`
`218`		`- set_tsk_thread_flag(child, TIF_SIGPENDING);`
`219`	`217`	`}`
`220`	`218`	`else`
`221`	`219`	`child->ptracer_cred = NULL;`