Skip to content

Commit 419e91e

Browse files
Wayne LinLyude
authored andcommitted
drm/dp_mst: Revise broadcast msg lct & lcr
[Why & How] According to DP spec, broadcast message LCT equals to 1 and LCR equals to 6. Current implementation is incorrect. Fix it. In addition, revise a bit the hdr->rad handling to include broadcast case. Signed-off-by: Wayne Lin <[email protected]> Cc: [email protected] Reviewed-by: Lyude Paul <[email protected]> Signed-off-by: Lyude Paul <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 66922f8 commit 419e91e

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

drivers/gpu/drm/drm_dp_mst_topology.c

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2827,10 +2827,15 @@ static int set_hdr_from_dst_qlock(struct drm_dp_sideband_msg_hdr *hdr,
28272827
else
28282828
hdr->broadcast = 0;
28292829
hdr->path_msg = txmsg->path_msg;
2830-
hdr->lct = mstb->lct;
2831-
hdr->lcr = mstb->lct - 1;
2832-
if (mstb->lct > 1)
2833-
memcpy(hdr->rad, mstb->rad, mstb->lct / 2);
2830+
if (hdr->broadcast) {
2831+
hdr->lct = 1;
2832+
hdr->lcr = 6;
2833+
} else {
2834+
hdr->lct = mstb->lct;
2835+
hdr->lcr = mstb->lct - 1;
2836+
}
2837+
2838+
memcpy(hdr->rad, mstb->rad, hdr->lct / 2);
28342839

28352840
return 0;
28362841
}

0 commit comments

Comments
 (0)