SUNRPC: Fix stupid typo in xs_sock_set_reuseport

trondmypd · trondmypd · commit 402e23b4ed9e · 2015-02-09T17:31:02.000-05:00
Yes, kernel_setsockopt() hates you for using a char argument.

Signed-off-by: Trond Myklebust &lt;trond.myklebust@primarydata.com&gt;
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
@@ -1629,9 +1629,10 @@ static unsigned short xs_get_random_port(void)
  */
 static void xs_sock_set_reuseport(struct socket *sock)
 {
-	char opt = 1;
+	int opt = 1;
 
-	kernel_setsockopt(sock, SOL_SOCKET, SO_REUSEPORT, &opt, sizeof(opt));
+	kernel_setsockopt(sock, SOL_SOCKET, SO_REUSEPORT,
+			(char *)&opt, sizeof(opt));
 }
 
 static unsigned short xs_sock_getport(struct socket *sock)

Original file line number	Diff line number	Diff line change
`@@ -1629,9 +1629,10 @@ static unsigned short xs_get_random_port(void)`
`1629`	`1629`	`*/`
`1630`	`1630`	`static void xs_sock_set_reuseport(struct socket *sock)`
`1631`	`1631`	`{`
`1632`		`- char opt = 1;`
	`1632`	`+ int opt = 1;`
`1633`	`1633`
`1634`		`- kernel_setsockopt(sock, SOL_SOCKET, SO_REUSEPORT, &opt, sizeof(opt));`
	`1634`	`+ kernel_setsockopt(sock, SOL_SOCKET, SO_REUSEPORT,`
	`1635`	`+ (char *)&opt, sizeof(opt));`
`1635`	`1636`	`}`
`1636`	`1637`
`1637`	`1638`	`static unsigned short xs_sock_getport(struct socket *sock)`