Skip to content

Commit 3846189

Browse files
error27davem330
authored andcommitted
rxrpc: uninitialized variable in rxrpc_send_ack_packet()
The "pkt" was supposed to have been deleted in a previous patch. It leads to an uninitialized variable bug. Fixes: 72f0c6f ("rxrpc: Allocate ACK records at proposal and queue for transmission") Signed-off-by: Dan Carpenter <[email protected]> Acked-by: David Howells <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 101c1bb commit 3846189

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

net/rxrpc/output.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,6 @@ static void rxrpc_cancel_rtt_probe(struct rxrpc_call *call,
202202
static int rxrpc_send_ack_packet(struct rxrpc_local *local, struct rxrpc_txbuf *txb)
203203
{
204204
struct rxrpc_connection *conn;
205-
struct rxrpc_ack_buffer *pkt;
206205
struct rxrpc_call *call = txb->call;
207206
struct msghdr msg;
208207
struct kvec iov[1];
@@ -270,7 +269,6 @@ static int rxrpc_send_ack_packet(struct rxrpc_local *local, struct rxrpc_txbuf *
270269
rxrpc_set_keepalive(call);
271270
}
272271

273-
kfree(pkt);
274272
return ret;
275273
}
276274

0 commit comments

Comments
 (0)