HID: logitech: Prevent possibility of infinite loop when using /sys interface

mungewell · Jiri Kosina · commit 29ff66571d38 · 2014-08-15T10:54:13.000+02:00
If the device data is not accessible for some reason, returning 0 will cause the call to be
continuously called again as none of the string has been 'consumed'.

Signed-off-by: Simon Wood &lt;simon@mungewell.org&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.cz&gt;
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
@@ -451,13 +451,13 @@ static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *at
 	drv_data = hid_get_drvdata(hid);
 	if (!drv_data) {
 		hid_err(hid, "Private driver data not found!\n");
-		return 0;
+		return -EINVAL;
 	}
 
 	entry = drv_data->device_props;
 	if (!entry) {
 		hid_err(hid, "Device properties not found!\n");
-		return 0;
+		return -EINVAL;
 	}
 
 	if (range == 0)

Original file line number	Diff line number	Diff line change
`@@ -451,13 +451,13 @@ static ssize_t lg4ff_range_store(struct device dev, struct device_attribute at`
`451`	`451`	`drv_data = hid_get_drvdata(hid);`
`452`	`452`	`if (!drv_data) {`
`453`	`453`	`hid_err(hid, "Private driver data not found!\n");`
`454`		`- return 0;`
	`454`	`+ return -EINVAL;`
`455`	`455`	`}`
`456`	`456`
`457`	`457`	`entry = drv_data->device_props;`
`458`	`458`	`if (!entry) {`
`459`	`459`	`hid_err(hid, "Device properties not found!\n");`
`460`		`- return 0;`
	`460`	`+ return -EINVAL;`
`461`	`461`	`}`
`462`	`462`
`463`	`463`	`if (range == 0)`