Skip to content

Commit 29838dd

Browse files
Thomas Richterksacilotto
authored andcommitted
s390/cpum_sf.c: fix file permission for cpum_sfb_size
BugLink: https://bugs.launchpad.net/bugs/1908561 commit 78d732e upstream. This file is installed by the s390 CPU Measurement sampling facility device driver to export supported minimum and maximum sample buffer sizes. This file is read by lscpumf tool to display the details of the device driver capabilities. The lscpumf tool might be invoked by a non-root user. In this case it does not print anything because the file contents can not be read. Fix this by allowing read access for all users. Reading the file contents is ok, changing the file contents is left to the root user only. For further reference and details see: [1] ibm-s390-linux/s390-tools#97 Fixes: 69f239e ("s390/cpum_sf: Dynamically extend the sampling buffer if overflows occur") Cc: <[email protected]> # 3.14 Signed-off-by: Thomas Richter <[email protected]> Acked-by: Sumanth Korikkar <[email protected]> Signed-off-by: Heiko Carstens <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Kamal Mostafa <[email protected]> Signed-off-by: Ian May <[email protected]>
1 parent 3194eb0 commit 29838dd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/s390/kernel/perf_cpum_sf.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2217,4 +2217,4 @@ static int __init init_cpum_sampling_pmu(void)
22172217
}
22182218

22192219
arch_initcall(init_cpum_sampling_pmu);
2220-
core_param(cpum_sfb_size, CPUM_SF_MAX_SDB, sfb_size, 0640);
2220+
core_param(cpum_sfb_size, CPUM_SF_MAX_SDB, sfb_size, 0644);

0 commit comments

Comments
 (0)