Skip to content

Commit 1eddfe8

Browse files
committed
Smack: Three symbols that should be static
The kbuild test robot reported a couple of these, and the third showed up by inspection. Making the symbols static is proper. Reported-by: Fengguang Wu <[email protected]> Signed-off-by: Casey Schaufler <[email protected]>
1 parent 21abb1e commit 1eddfe8

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

security/smack/smack_lsm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ static struct smack_known *smk_fetch(const char *name, struct inode *ip,
291291
*
292292
* Returns the new blob or NULL if there's no memory available
293293
*/
294-
struct inode_smack *new_inode_smack(struct smack_known *skp)
294+
static struct inode_smack *new_inode_smack(struct smack_known *skp)
295295
{
296296
struct inode_smack *isp;
297297

@@ -4516,7 +4516,7 @@ static int smack_inode_getsecctx(struct inode *inode, void **ctx, u32 *ctxlen)
45164516
return 0;
45174517
}
45184518

4519-
struct security_hook_list smack_hooks[] = {
4519+
static struct security_hook_list smack_hooks[] = {
45204520
LSM_HOOK_INIT(ptrace_access_check, smack_ptrace_access_check),
45214521
LSM_HOOK_INIT(ptrace_traceme, smack_ptrace_traceme),
45224522
LSM_HOOK_INIT(syslog, smack_syslog),

security/smack/smackfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ struct smack_master_list {
139139
struct smack_rule *smk_rule;
140140
};
141141

142-
LIST_HEAD(smack_rule_list);
142+
static LIST_HEAD(smack_rule_list);
143143

144144
struct smack_parsed_rule {
145145
struct smack_known *smk_subject;

0 commit comments

Comments
 (0)