Skip to content

Commit 1dd0d7f

Browse files
tmlindherbertx
authored andcommitted
crypto: omap-sham - drop pm_runtime_irqsafe() usage
Commit b0a3d89 ("crypto: omap-sham - Use pm_runtime_irq_safe()") added the use of pm_runtime_irq_safe() as pm_runtime_get_sync() was called from a tasklet. We now use the crypto engine queue instead of a custom queue since commit 33c3d434d91 ("crypto: omap-sham - convert to use crypto engine"). We want to drop the use of pm_runtime_irq_safe() in general as it takes a permanent usage count on the parent device causing issues for power management. Based on testing with CONFIG_DEBUG_ATOMIC_SLEEP=y, modprobe omap-sham, followed by modprobe tcrypt sec=1 mode=423, I have not been able to reproduce the scheduling while atomic issue seen earlier with current kernels and we can just drop the call to pm_runtime_irq_safe(). Cc: Lokesh Vutla <[email protected]> Cc: Tero Kristo <[email protected]> Signed-off-by: Tony Lindgren <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
1 parent 70c68d1 commit 1dd0d7f

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/crypto/omap-sham.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2113,7 +2113,6 @@ static int omap_sham_probe(struct platform_device *pdev)
21132113
dd->fallback_sz = OMAP_SHA_DMA_THRESHOLD;
21142114

21152115
pm_runtime_enable(dev);
2116-
pm_runtime_irq_safe(dev);
21172116

21182117
err = pm_runtime_get_sync(dev);
21192118
if (err < 0) {

0 commit comments

Comments
 (0)