Skip to content

Commit 136ae5e

Browse files
bentissJiri Kosina
authored andcommitted
HID: wacom: power_supply: remove ac information
Looks like upowerd is ignoring this since October 2013, so there is no need to keep this around in the kernel. And as mentioned in 8aaa592 (linux: Ignore ACs coming from devices) in the upower tree, "We already have enough information on the device battery". Signed-off-by: Benjamin Tissoires <[email protected]> Acked-by: Ping Cheng <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 9698329 commit 136ae5e

File tree

2 files changed

+1
-51
lines changed

2 files changed

+1
-51
lines changed

drivers/hid/wacom.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,8 @@ struct wacom_group_leds {
135135

136136
struct wacom_battery {
137137
struct power_supply_desc bat_desc;
138-
struct power_supply_desc ac_desc;
139138
struct power_supply *battery;
140-
struct power_supply *ac;
141139
char bat_name[WACOM_NAME_MAX];
142-
char ac_name[WACOM_NAME_MAX];
143140
int battery_capacity;
144141
int bat_charging;
145142
int bat_connected;

drivers/hid/wacom_sys.c

Lines changed: 1 addition & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -1342,12 +1342,6 @@ static enum power_supply_property wacom_battery_props[] = {
13421342
POWER_SUPPLY_PROP_CAPACITY
13431343
};
13441344

1345-
static enum power_supply_property wacom_ac_props[] = {
1346-
POWER_SUPPLY_PROP_PRESENT,
1347-
POWER_SUPPLY_PROP_ONLINE,
1348-
POWER_SUPPLY_PROP_SCOPE,
1349-
};
1350-
13511345
static int wacom_battery_get_property(struct power_supply *psy,
13521346
enum power_supply_property psp,
13531347
union power_supply_propval *val)
@@ -1384,38 +1378,14 @@ static int wacom_battery_get_property(struct power_supply *psy,
13841378
return ret;
13851379
}
13861380

1387-
static int wacom_ac_get_property(struct power_supply *psy,
1388-
enum power_supply_property psp,
1389-
union power_supply_propval *val)
1390-
{
1391-
struct wacom_battery *battery = power_supply_get_drvdata(psy);
1392-
int ret = 0;
1393-
1394-
switch (psp) {
1395-
case POWER_SUPPLY_PROP_PRESENT:
1396-
/* fall through */
1397-
case POWER_SUPPLY_PROP_ONLINE:
1398-
val->intval = battery->ps_connected;
1399-
break;
1400-
case POWER_SUPPLY_PROP_SCOPE:
1401-
val->intval = POWER_SUPPLY_SCOPE_DEVICE;
1402-
break;
1403-
default:
1404-
ret = -EINVAL;
1405-
break;
1406-
}
1407-
return ret;
1408-
}
1409-
14101381
static int __wacom_initialize_battery(struct wacom *wacom,
14111382
struct wacom_battery *battery)
14121383
{
14131384
static atomic_t battery_no = ATOMIC_INIT(0);
14141385
struct device *dev = &wacom->hdev->dev;
14151386
struct power_supply_config psy_cfg = { .drv_data = battery, };
1416-
struct power_supply *ps_bat, *ps_ac;
1387+
struct power_supply *ps_bat;
14171388
struct power_supply_desc *bat_desc = &battery->bat_desc;
1418-
struct power_supply_desc *ac_desc = &battery->ac_desc;
14191389
unsigned long n;
14201390
int error;
14211391

@@ -1432,31 +1402,15 @@ static int __wacom_initialize_battery(struct wacom *wacom,
14321402
bat_desc->type = POWER_SUPPLY_TYPE_USB;
14331403
bat_desc->use_for_apm = 0;
14341404

1435-
ac_desc->properties = wacom_ac_props;
1436-
ac_desc->num_properties = ARRAY_SIZE(wacom_ac_props);
1437-
ac_desc->get_property = wacom_ac_get_property;
1438-
sprintf(battery->ac_name, "wacom_ac_%ld", n);
1439-
ac_desc->name = battery->ac_name;
1440-
ac_desc->type = POWER_SUPPLY_TYPE_MAINS;
1441-
ac_desc->use_for_apm = 0;
1442-
14431405
ps_bat = devm_power_supply_register(dev, bat_desc, &psy_cfg);
14441406
if (IS_ERR(ps_bat)) {
14451407
error = PTR_ERR(ps_bat);
14461408
goto err;
14471409
}
14481410

1449-
ps_ac = devm_power_supply_register(dev, ac_desc, &psy_cfg);
1450-
if (IS_ERR(ps_ac)) {
1451-
error = PTR_ERR(ps_ac);
1452-
goto err;
1453-
}
1454-
14551411
power_supply_powers(ps_bat, &wacom->hdev->dev);
1456-
power_supply_powers(ps_ac, &wacom->hdev->dev);
14571412

14581413
battery->battery = ps_bat;
1459-
battery->ac = ps_ac;
14601414

14611415
devres_close_group(dev, bat_desc);
14621416
return 0;
@@ -1480,7 +1434,6 @@ static void wacom_destroy_battery(struct wacom *wacom)
14801434
devres_release_group(&wacom->hdev->dev,
14811435
&wacom->battery.bat_desc);
14821436
wacom->battery.battery = NULL;
1483-
wacom->battery.ac = NULL;
14841437
}
14851438
}
14861439

0 commit comments

Comments
 (0)