Skip to content

Conversation

@johannesduesing
Copy link

Reason for this PR
The API of the Instance Registry has been change lately. The goal was to support new UI requirements. The relevant changes are:

  • /matchingInstance and /matchingResult now require an additional parameter containing the caller-Id
  • The Instance now has a new attribute called labels of type List[String]

This PR adapts the WebApi to support the new API version. The same has been done for the crawler here.

Changes

  • Added attribute labels: List[String] to case class Instance
  • Changed calls to /matchingInstance and /matchingResult to post the parameter callerId as well

@johannesduesing johannesduesing self-assigned this Nov 8, 2018
@ghost ghost added the review label Nov 8, 2018
@codecov
Copy link

codecov bot commented Nov 8, 2018

Codecov Report

Merging #33 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #33      +/-   ##
==========================================
- Coverage     1.58%   1.58%   -0.01%     
==========================================
  Files           14      14              
  Lines          378     379       +1     
  Branches        22      28       +6     
==========================================
  Hits             6       6              
- Misses         372     373       +1
Impacted Files Coverage Δ
...la/de/upb/cs/swt/delphi/webapi/Configuration.scala 0% <ø> (ø) ⬆️
...pb/cs/swt/delphi/instancemanagement/Instance.scala 0% <0%> (ø) ⬆️
...t/delphi/instancemanagement/InstanceRegistry.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5e1f2...d2f3ac7. Read the comment docs.

@johannesduesing johannesduesing changed the title Feature/new matching interface Adapt WebApi to latest changes in the registry Nov 8, 2018
@bhermann bhermann merged commit c2441e8 into develop Nov 8, 2018
@ghost ghost removed the review label Nov 8, 2018
@bhermann bhermann deleted the feature/newMatchingInterface branch November 8, 2018 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants