Feature/deploy script #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannesduesing
requested changes
Jan 20, 2019
Contributor
johannesduesing
left a comment
johannesduesing
left a comment
There was a problem hiding this comment.
Thanks for your PR 👍
Please have a look at the comments below regarding the readme and windows users.
|
|
||
| To obtain these images, checkout the respective repositories ([here](https://github.com/delphi-hub/delphi-crawler), [here](https://github.com/delphi-hub/delphi-webapi) and [here](https://github.com/delphi-hub/delphi-webapp)) and execute the command | ||
| To obtain these images, please checkout the Delphi registry repository and execute the command | ||
|
|
Contributor
There was a problem hiding this comment.
Please also keep the old content of the readme and address both Windows and Linux. I thought of something like this:
"For Linux, please execute the setup script located at [...], for windows ."
Collaborator
Author
There was a problem hiding this comment.
Thanks for the review. I have made the requested changes. Could you please review and let me know for any other changes.
| For building a docker image containing the registry, go to the root folder of the repository and execute ```sbt docker:publishLocal```. This will build the application, create a docker image named ```delphi-registry:1.0.0-SNAPSHOT```, and register the image at your local docker registry. | ||
|
|
||
| The installation script mentioned in section **Requirements** will also create docker image for registry named ```delphi-registry:1.0.0-SNAPSHOT```, and registers the image at your local docker registry. | ||
|
|
Contributor
There was a problem hiding this comment.
Same as above, please also keep Windows users in mind.
24santoshr
force-pushed
the
feature/deploy_script
branch
from
0dfd18d to
2e669bd
Compare
johannesduesing
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for PR
This PR contains the deployment script for cloning the delphi repositories and also builds the docker images for all the delphi components.