Skip to content

Vulnerability fix #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 26, 2019
Merged

Vulnerability fix #155

merged 6 commits into from
Nov 26, 2019

Conversation

@hariharansrc
Copy link
Member

@hariharansrc hariharansrc commented Nov 22, 2019

  • Merge branch 'master' into develop
  • Upgraded play sbt plugin to 2.7.3
  • Upgraded play-bootstrap to 1.5-P27-B3
  • Upgraded jackson-databind to 2.9.10.1
  • Upgraded akka http spray json to 10.1.6
  • Excluded some vulnearable jars transitive jar and added upgraded
    the dependency

ishwaryamamidi and others added 4 commits March 30, 2019 12:58
@ishwaryamamidi
Merge pull request #143 from delphi-hub/release/1.0.0
c43af82 
Release/1.0.0
Merge branch 'master' into develop
566a8cb
- Upgraded play sbt plugin to 2.7.3
a449878 
- Upgraded native packager to 1.3.15
- Upgraded codacy to 1.3.14
- Upgraded play-bootstrap to 1.5-P27-B3
941fefd 
- Upgraded jackson-databind to 2.9.10.1
- Upgraded akka http spray json to 10.1.6
- Excluded some vulnearable jars transitive jar and added upgraded
  the dependency
Hariharan Ramanathan added 2 commits November 22, 2019 14:46
Configure compilation issue needs override.
4a90c04
Fixing test case because of compilation failure.
76a9c10 
Commit ecef020 has similar issue not
newly introduced by vulnerability fixes
hariharansrc
hariharansrc commented Nov 22, 2019
View reviewed changes
test/systeminfotest/SystemInfoTest.scala
// a simple test case can be replaced with a better one
"SystemInfo" should {
"should return a valid SystemInfo Json" in {
val controller = new SystemInfoController(stubControllerComponents())
Copy link
Member Author

@hariharansrc hariharansrc Nov 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/delphi-hub/delphi-management/blob/master/app/controllers/SystemInfoController.scala

hariharansrc
hariharansrc commented Nov 22, 2019
View reviewed changes
app/module/Module.scala
*
* @return
*/
def configure() {
Copy link
Member Author

@hariharansrc hariharansrc Nov 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need override

@hariharansrc
Copy link
Member Author

hariharansrc commented Nov 22, 2019 •
edited
Loading

I guess CODACY_PROJECT_TOKEN environmental variable need to be updated

@bhermann bhermann merged commit 2fe0f73 into develop Nov 26, 2019
@bhermann bhermann deleted the vulnerability_fix branch November 26, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhermann bhermann Awaiting requested review from bhermann

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hariharansrc @bhermann @ishwaryamamidi