Item graph display too many items #1367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/slow-itemgraph
|
| Run status |
|
| Run duration | 07m 51s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
336
|
| View all changes introduced in this branch ↗︎ | |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1367 +/- ##
==========================================
+ Coverage 80.10% 80.44% +0.34%
==========================================
Files 70 70
Lines 4759 4771 +12
==========================================
+ Hits 3812 3838 +26
+ Misses 947 933 -14
🚀 New features to boost your workflow:
|
ml-evs
force-pushed
the
bc/slow-itemgraph
branch
from
8957193 to
cd78230
Compare
BenjaminCharmes
force-pushed
the
bc/slow-itemgraph
branch
from
c758d57 to
811cf06
Compare
Re-add old comments Re-add old comments Fix test_graph.py with right numbers of nodes and edges for each test (for items and collections) Add test for item graph difference between admins and users (#1360) Re-add get_graph_cy_format modification Fix pytest Re-add user_only=False Re-add user_only=False
ml-evs
force-pushed
the
bc/slow-itemgraph
branch
from
811cf06 to
07804f2
Compare
ml-evs
previously approved these changes
Oct 28, 2025
There was a problem hiding this comment.
Thanks @BenjaminCharmes, only one minor change that I'll commit myself before merging!
ml-evs
added
bug
BenjaminCharmes
added a commit
that referenced
this pull request
Oct 29, 2025
Co-authored-by: Matthew Evans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1355
Test from #1360 work with this fix (local at least)