From 527744f9edb8ca5d1c14ad02556573a7c4db5c90 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sun, 31 Jan 2021 05:36:33 -0500 Subject: [PATCH 1/7] spelling: deployed Signed-off-by: Josh Soref --- README.md | 2 +- cmd/root.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 07913eb1..0fc5c868 100644 --- a/README.md +++ b/README.md @@ -67,7 +67,7 @@ The Helm Diff Plugin * Shows a diff explaining what a helm rollback would change: This fetches the currently deployed version of a release - and compares it to adeployed versions of a release, that you + and compares it to deployed versions of a release, that you want to rollback. This can be used visualize what changes a helm rollback will perform. diff --git a/cmd/root.go b/cmd/root.go index 246274a8..910be187 100644 --- a/cmd/root.go +++ b/cmd/root.go @@ -23,7 +23,7 @@ The Helm Diff Plugin * Shows a diff explaining what a helm rollback would change: This fetches the currently deployed version of a release - and compares it to adeployed versions of a release, that you + and compares it to deployed versions of a release, that you want to rollback. This can be used visualize what changes a helm rollback will perform. ` From b30bcf08d00ac6a134582823550844e7fea3378e Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sun, 31 Jan 2021 05:36:34 -0500 Subject: [PATCH 2/7] spelling: didn't Signed-off-by: Josh Soref --- diff/report.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/diff/report.go b/diff/report.go index 4bfd830c..59bfab86 100644 --- a/diff/report.go +++ b/diff/report.go @@ -202,7 +202,7 @@ func (t *ReportTemplateSpec) loadFromKey(key string) error { t.API = matches[4] return nil } - return errors.New("key string did't match regexp") + return errors.New("key string didn't match regexp") } // load and print report for template output From 27911f8544a2609f257adf020e8f437649eadad5 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sun, 31 Jan 2021 05:36:35 -0500 Subject: [PATCH 3/7] spelling: latest manifest Signed-off-by: Josh Soref --- README.md | 2 +- cmd/rollback.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 0fc5c868..21510eaf 100644 --- a/README.md +++ b/README.md @@ -208,7 +208,7 @@ Global Flags: ``` $ helm diff rollback -h -This command compares the laset manifests details of a named release +This command compares the latest manifest details of a named release with specific revision values to rollback. It forecasts/visualizes changes, that a helm rollback could perform. diff --git a/cmd/rollback.go b/cmd/rollback.go index 68ba99c0..9d46050c 100644 --- a/cmd/rollback.go +++ b/cmd/rollback.go @@ -28,7 +28,7 @@ type rollback struct { } const rollbackCmdLongUsage = ` -This command compares the laset manifests details of a named release +This command compares the latest manifest details of a named release with specific revision values to rollback. It forecasts/visualizes changes, that a helm rollback could perform. From 57dc095ab12e3599fe576b1993950c077b8c63cd Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sun, 31 Jan 2021 05:36:36 -0500 Subject: [PATCH 4/7] spelling: loading Signed-off-by: Josh Soref --- diff/report.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/diff/report.go b/diff/report.go index 59bfab86..a78718e6 100644 --- a/diff/report.go +++ b/diff/report.go @@ -150,7 +150,7 @@ func newTemplate(name string) *template.Template { func setupJSONReport(r *Report) { t, err := newTemplate("entries").Parse(defaultTemplateReport) if err != nil { - log.Fatalf("Error loadding default template: %v", err) + log.Fatalf("Error loading default template: %v", err) } r.format.output = templateReportPrinter(t) @@ -170,14 +170,14 @@ func setupTemplateReport(r *Report) { t, err := newTemplate(filepath.Base(tplFile)).ParseFiles(tplFile) if err != nil { fmt.Println(err) - log.Fatalf("Error loadding custom template") + log.Fatalf("Error loading custom template") } tpl = t } else { // Render t, err := newTemplate("entries").Parse(defaultTemplateReport) if err != nil { - log.Fatalf("Error loadding default template") + log.Fatalf("Error loading default template") } tpl = t } From 9aa03483ab39a2f22521cdd145b9db77bb7579da Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sun, 31 Jan 2021 05:36:37 -0500 Subject: [PATCH 5/7] spelling: separator Signed-off-by: Josh Soref --- manifest/parse.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/manifest/parse.go b/manifest/parse.go index ebfd9fec..68d08e03 100644 --- a/manifest/parse.go +++ b/manifest/parse.go @@ -15,7 +15,7 @@ const ( hookAnnotation = "helm.sh/hook" ) -var yamlSeperator = []byte("\n---\n") +var yamlSeparator = []byte("\n---\n") // MappingResult to store result of diff type MappingResult struct { @@ -48,9 +48,9 @@ func scanYamlSpecs(data []byte, atEOF bool) (advance int, token []byte, err erro if atEOF && len(data) == 0 { return 0, nil, nil } - if i := bytes.Index(data, yamlSeperator); i >= 0 { + if i := bytes.Index(data, yamlSeparator); i >= 0 { // We have a full newline-terminated line. - return i + len(yamlSeperator), data[0:i], nil + return i + len(yamlSeparator), data[0:i], nil } // If we're at EOF, we have a final, non-terminated line. Return it. if atEOF { @@ -84,7 +84,7 @@ func ParseRelease(release *release.Release, includeTests bool, normalizeManifest // Parse parses manifest strings into MappingResult func Parse(manifest string, defaultNamespace string, normalizeManifests bool, excludedHooks ...string) map[string]*MappingResult { - // Ensure we have a newline in front of the yaml seperator + // Ensure we have a newline in front of the yaml separator scanner := bufio.NewScanner(strings.NewReader("\n" + manifest)) scanner.Split(scanYamlSpecs) // Allow for tokens (specs) up to 10MiB in size From 4616426548c09c195d2afc0f7fc3b63c91a9a39a Mon Sep 17 00:00:00 2001 From: Yusuke Kuoka Date: Tue, 1 Jun 2021 13:41:13 +0900 Subject: [PATCH 6/7] Update cmd/root.go --- cmd/root.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/root.go b/cmd/root.go index 910be187..e20b7755 100644 --- a/cmd/root.go +++ b/cmd/root.go @@ -23,7 +23,7 @@ The Helm Diff Plugin * Shows a diff explaining what a helm rollback would change: This fetches the currently deployed version of a release - and compares it to deployed versions of a release, that you + and compares it to the previously deployed version of the release, that you want to rollback. This can be used visualize what changes a helm rollback will perform. ` From c598f2158cfbec4aa57bb7e6e111a1f5f9a2d981 Mon Sep 17 00:00:00 2001 From: Yusuke Kuoka Date: Tue, 1 Jun 2021 13:41:20 +0900 Subject: [PATCH 7/7] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 21510eaf..55a58e3a 100644 --- a/README.md +++ b/README.md @@ -67,7 +67,7 @@ The Helm Diff Plugin * Shows a diff explaining what a helm rollback would change: This fetches the currently deployed version of a release - and compares it to deployed versions of a release, that you + and compares it to the previously deployed versions of the release, that you want to rollback. This can be used visualize what changes a helm rollback will perform.